Fix MonitoredVideoStubTest failure in memory runs

remoting/protocol/monitored_video_stub_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/protocol/monitored_video_stub.h"
 
 #include "base/message_loop/message_loop.h"
 #include "base/message_loop/message_loop_proxy.h"
 #include "base/run_loop.h"
 #include "base/test/test_timeouts.h"
 #include "remoting/protocol/protocol_mock_objects.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using ::testing::_;
 using ::testing::AnyNumber;
+using ::testing::AtMost;
 using ::testing::InvokeWithoutArgs;
 
 namespace remoting {
 namespace protocol {
 
 static const int64 kTestOverrideDelayMilliseconds = 1;
 
 class MonitoredVideoStubTest : public testing::Test {
  protected:
   virtual void SetUp() OVERRIDE {
@@ skipping 12 matching lines @@
   base::MessageLoop message_loop_;
   MockVideoStub video_stub_;
 
   scoped_ptr<MonitoredVideoStub> monitor_;
   scoped_ptr<VideoPacket> packet_;
   base::OneShotTimer<MonitoredVideoStubTest> timer_end_test_;
 };
 
 TEST_F(MonitoredVideoStubTest, OnChannelConnected) {
   EXPECT_CALL(*this, OnVideoChannelStatus(true));
+  // On slow machines, the connectivity check timer may fires before the test

[Jamie, 2014/05/02 01:06:32]

s/fires/fire/, here and below.

[kelvinp, 2014/05/02 01:11:14]

Done.

+  // finishes, so we expect to see at most one transition to not ready.
+  EXPECT_CALL(*this, OnVideoChannelStatus(false)).Times(AtMost(1));
+
   monitor_->ProcessVideoPacket(packet_.Pass(), base::Closure());
   base::RunLoop().RunUntilIdle();
 }
 
 TEST_F(MonitoredVideoStubTest, OnChannelDisconnected) {
   EXPECT_CALL(*this, OnVideoChannelStatus(true));
   monitor_->ProcessVideoPacket(packet_.Pass(), base::Closure());
 
   EXPECT_CALL(*this, OnVideoChannelStatus(false)).WillOnce(
     InvokeWithoutArgs(
       &message_loop_,
       &base::MessageLoop::Quit));
   message_loop_.Run();
 }
 
 TEST_F(MonitoredVideoStubTest, OnChannelStayConnected) {
   // Verify no extra connected events are fired when packets are received
   // frequently
-  EXPECT_CALL(*this, OnVideoChannelStatus(_)).Times(1);
+  EXPECT_CALL(*this, OnVideoChannelStatus(true));
+  // On slow machines, the connectivity check timer may fires before the test
+  // finishes, so we expect to see at most one transition to not ready.
+  EXPECT_CALL(*this, OnVideoChannelStatus(false)).Times(AtMost(1));
 
   monitor_->ProcessVideoPacket(packet_.Pass(), base::Closure());
   monitor_->ProcessVideoPacket(packet_.Pass(), base::Closure());
   base::RunLoop().RunUntilIdle();
 }
 
 TEST_F(MonitoredVideoStubTest, OnChannelStayDisconnected) {
   // Verify no extra disconnected events are fired.
   EXPECT_CALL(*this, OnVideoChannelStatus(true)).Times(1);
   EXPECT_CALL(*this, OnVideoChannelStatus(false)).Times(1);
 
   monitor_->ProcessVideoPacket(packet_.Pass(), base::Closure());
 
   message_loop_.PostDelayedTask(
       FROM_HERE,
       base::MessageLoop::QuitClosure(),
       // The delay should be much greater than |kTestOverrideDelayMilliseconds|.
       TestTimeouts::tiny_timeout());
   message_loop_.Run();
 }
 
 }  // namespace protocol
 }  // namespace remoting