Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 267623002: Fix Trusty build with clang. (Closed)

Created:
6 years, 7 months ago by dcheng
Modified:
6 years, 7 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Fix Trusty build with clang. In file included from ../../net/proxy/proxy_config_service_linux.cc:42: gen/library_loaders/libgio.h:29:13: error: 'g_settings_list_schemas' is deprecated [-Werror,-Wdeprecated-declarations] typeof(&::g_settings_list_schemas) g_settings_list_schemas; ^ /usr/include/glib-2.0/gio/gsettings.h:74:25: note: 'g_settings_list_sch emas' has been explicitly marked deprecated here const gchar * const * g_settings_list_schemas (void); ^ 1 error generated. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267454

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M net/proxy/proxy_config_service_linux.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
dcheng
6 years, 7 months ago (2014-04-30 21:40:44 UTC) #1
Ryan Sleevi
lgtm
6 years, 7 months ago (2014-04-30 23:05:44 UTC) #2
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 7 months ago (2014-04-30 23:09:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/267623002/1
6 years, 7 months ago (2014-04-30 23:09:57 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 23:14:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium
6 years, 7 months ago (2014-04-30 23:14:32 UTC) #6
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 7 months ago (2014-04-30 23:24:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/267623002/20001
6 years, 7 months ago (2014-04-30 23:25:31 UTC) #8
commit-bot: I haz the power
Change committed as 267454
6 years, 7 months ago (2014-05-01 06:04:48 UTC) #9
Matt Giuca
I'm concerned that this fix is Clang-only, when the issue appears to affect all compilers. ...
6 years, 7 months ago (2014-05-04 23:40:52 UTC) #10
dcheng
On 2014/05/04 23:40:52, Matt Giuca wrote: > I'm concerned that this fix is Clang-only, when ...
6 years, 7 months ago (2014-05-05 00:47:38 UTC) #11
Matt Giuca
6 years, 7 months ago (2014-05-05 12:11:44 UTC) #12
Message was sent while issue was closed.
> Sorry, this was a quick and dirty patch in the interest of unblocking myself.
If
> this is affecting all compilers, I would be in favor of replacing this with a
> better solution.

No problem (I think it was worth unblocking the majority of users quickly),
thanks for letting me know. Indeed I just tested it with GCC and it is still an
issue, so I will go ahead with my patch.

Powered by Google App Engine
This is Rietveld 408576698