Add EditingStyleUtilities.{cpp,h}

Add EditingStyleUtilities.{cpp,h}

EditingStyle is used to deal with CSS styles in editing. but it has
many static methods to create an EditingStyle and some of the methods
don't access member variables so they can be split into
EditingStyleUtilities class.

This CL copies EditingStyle.{cpp,h} to EditingStyleUtilities.{cpp,h}
as part of refactoring EditingStyle class.

BUG=679817
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2649613002
Cr-Commit-Position: refs/heads/master@{#448866}
Committed: https://chromium.googlesource.com/chromium/src/+/3f6dfe4978e72853c4debad300c97b4d3872ad89

[joone, 2017-01-20 19:38:14]

Description was changed from

==========
Add EditingStyleUtilities.{cpp,h}

EditingStyle is used to deal with CSS styles in editing. but it has
many static methods to create a EditingStyle and some of the methods
don't access member variables so they can be split into
EditingStyleUtilities class.

This CL copys some static methods to EditingStyleUtilities as part of
introducing EditingStyleUtilities class.

BUG=679817
TEST=n/a; no behavior changes
==========

to

==========
Add EditingStyleUtilities.{cpp,h}

EditingStyle is used to deal with CSS styles in editing. but it has
many static methods to create an EditingStyle and some of the methods
don't access member variables so they can be split into
EditingStyleUtilities class.

This CL copies some static methods to EditingStyleUtilities as part of
introducing EditingStyleUtilities class.

BUG=679817
TEST=n/a; no behavior changes
==========

[joone, 2017-01-20 19:39:52]

yosin@ I've created the first CL as part of
https://codereview.chromium.org/2628943009/

Thanks!

[joone, 2017-01-20 19:45:15]

joone.hur@intel.com changed reviewers:
+ yosin@chromium.org

[yosin_UTC9, 2017-01-23 02:27:25]

This patch makes we loose change history.

Please see below for keeping history:

For ease of history tracking and reviewing, could you split this patch into
1. Copy EditingStyle.{cpp,h} to EditingStyleUtilities.{cpp,h}
 - adjust include guard for pass PRESUBMIT; no other changes are expected.
2. Finish EditingStyleUtitilies.{cpp,h} + BUILD.gn
 - Rename EditingStyle to EditingStyleUtilities
 - Delete code only for EditingStyle
3. Rename call sites to |EditingStyleUtilitis::|
4. Get rid of moved functions from EdigintStyle.{cpp,h}

[joone, 2017-01-23 05:14:59]

On 2017/01/23 02:27:25, Yosi_UTC9 wrote:
> This patch makes we loose change history.
> 
> Please see below for keeping history:
> 
> For ease of history tracking and reviewing, could you split this patch into
> 1. Copy EditingStyle.{cpp,h} to EditingStyleUtilities.{cpp,h}
>  - adjust include guard for pass PRESUBMIT; no other changes are expected.

I didn't think that I had to copy the whole EditingStyle.{cpp,h} to
EditingStyleUtilities.{cpp.h} without changes.

> 2. Finish EditingStyleUtitilies.{cpp,h} + BUILD.gn
>  - Rename EditingStyle to EditingStyleUtilities
>  - Delete code only for EditingStyle
> 3. Rename call sites to |EditingStyleUtilitis::|
> 4. Get rid of moved functions from EdigintStyle.{cpp,h}

I will update this CL soon.

[joone, 2017-01-23 06:58:15]

Description was changed from

==========
Add EditingStyleUtilities.{cpp,h}

EditingStyle is used to deal with CSS styles in editing. but it has
many static methods to create an EditingStyle and some of the methods
don't access member variables so they can be split into
EditingStyleUtilities class.

This CL copies some static methods to EditingStyleUtilities as part of
introducing EditingStyleUtilities class.

BUG=679817
TEST=n/a; no behavior changes
==========

to

==========
Add EditingStyleUtilities.{cpp,h}

EditingStyle is used to deal with CSS styles in editing. but it has
many static methods to create an EditingStyle and some of the methods
don't access member variables so they can be split into
EditingStyleUtilities class.

This CL copies EditingStyle.{cpp,h} to  EditingStyleUtilities.{cpp,h} as part of
refactoring EditingStyle class.

BUG=679817
TEST=n/a; no behavior changes
==========

[joone, 2017-01-23 06:58:26]

Description was changed from

==========
Add EditingStyleUtilities.{cpp,h}

EditingStyle is used to deal with CSS styles in editing. but it has
many static methods to create an EditingStyle and some of the methods
don't access member variables so they can be split into
EditingStyleUtilities class.

This CL copies EditingStyle.{cpp,h} to  EditingStyleUtilities.{cpp,h} as part of
refactoring EditingStyle class.

BUG=679817
TEST=n/a; no behavior changes
==========

to

==========
Add EditingStyleUtilities.{cpp,h}

EditingStyle is used to deal with CSS styles in editing. but it has
many static methods to create an EditingStyle and some of the methods
don't access member variables so they can be split into
EditingStyleUtilities class.

This CL copies EditingStyle.{cpp,h} to  EditingStyleUtilities.{cpp,h}
as part of refactoring EditingStyle class.

BUG=679817
TEST=n/a; no behavior changes
==========

[joone, 2017-01-23 07:00:44]

Description was changed from

==========
Add EditingStyleUtilities.{cpp,h}

EditingStyle is used to deal with CSS styles in editing. but it has
many static methods to create an EditingStyle and some of the methods
don't access member variables so they can be split into
EditingStyleUtilities class.

This CL copies EditingStyle.{cpp,h} to  EditingStyleUtilities.{cpp,h}
as part of refactoring EditingStyle class.

BUG=679817
TEST=n/a; no behavior changes
==========

to

==========
Add EditingStyleUtilities.{cpp,h}

EditingStyle is used to deal with CSS styles in editing. but it has
many static methods to create an EditingStyle and some of the methods
don't access member variables so they can be split into
EditingStyleUtilities class.

This CL copies EditingStyle.{cpp,h} to EditingStyleUtilities.{cpp,h}
as part of refactoring EditingStyle class.

BUG=679817
TEST=n/a; no behavior changes
==========

[joone, 2017-01-23 07:02:50]

yosin@ please review the updated CL.

[yosin_UTC9, 2017-01-23 08:16:07]

We should see "A+" marks for copied files.
I've tried but I also could not get "A+" mark:
https://codereview.chromium.org/2649853002
I'm using Windows.

Do you use Linux?

[joone, 2017-01-23 08:21:37]

On 2017/01/23 08:16:07, Yosi_UTC9 wrote:
> We should see "A+" marks for copied files.
> I've tried but I also could not get "A+" mark:
> https://codereview.chromium.org/2649853002
> I'm using Windows.
> 
> Do you use Linux?

Yes.

[yosin_UTC9, 2017-01-23 08:23:26]

On 2017/01/23 at 08:21:37, joone.hur wrote:
> On 2017/01/23 08:16:07, Yosi_UTC9 wrote:
> > We should see "A+" marks for copied files.
> > I've tried but I also could not get "A+" mark:
> > https://codereview.chromium.org/2649853002
> > I'm using Windows.
> > 
> > Do you use Linux?
> 
> Yes.

Does "--find-copies" option work in "git diff" and "git cl upload"?

[joone, 2017-01-23 08:39:16]

Patchset #3 (id:40001) has been deleted

[joone, 2017-01-23 08:39:41]

On 2017/01/23 08:23:26, Yosi_UTC9 wrote:
> On 2017/01/23 at 08:21:37, joone.hur wrote:
> > On 2017/01/23 08:16:07, Yosi_UTC9 wrote:
> > > We should see "A+" marks for copied files.
> > > I've tried but I also could not get "A+" mark:
> > > https://codereview.chromium.org/2649853002
> > > I'm using Windows.
> > > 
> > > Do you use Linux?
> > 
> > Yes.
> 
> Does "--find-copies" option work in "git diff" and "git cl upload"?

No, it doesn't work.

[yosin_UTC9, 2017-01-23 09:05:55]

On 2017/01/23 at 08:39:41, joone.hur wrote:
> On 2017/01/23 08:23:26, Yosi_UTC9 wrote:
> > On 2017/01/23 at 08:21:37, joone.hur wrote:
> > > On 2017/01/23 08:16:07, Yosi_UTC9 wrote:
> > > > We should see "A+" marks for copied files.
> > > > I've tried but I also could not get "A+" mark:
> > > > https://codereview.chromium.org/2649853002
> > > > I'm using Windows.
> > > > 
> > > > Do you use Linux?
> > > 
> > > Yes.
> > 
> > Does "--find-copies" option work in "git diff" and "git cl upload"?
> 
> No, it doesn't work.

Could you ask blink-dev@ to get A+ for copying file?

[yosin_UTC9, 2017-01-26 09:53:23]

On 2017/01/23 at 09:05:55, Yosi_UTC9 wrote:
> On 2017/01/23 at 08:39:41, joone.hur wrote:
> > On 2017/01/23 08:23:26, Yosi_UTC9 wrote:
> > > On 2017/01/23 at 08:21:37, joone.hur wrote:
> > > > On 2017/01/23 08:16:07, Yosi_UTC9 wrote:
> > > > > We should see "A+" marks for copied files.
> > > > > I've tried but I also could not get "A+" mark:
> > > > > https://codereview.chromium.org/2649853002
> > > > > I'm using Windows.
> > > > > 
> > > > > Do you use Linux?
> > > > 
> > > > Yes.
> > > 
> > > Does "--find-copies" option work in "git diff" and "git cl upload"?
> > 
> > No, it doesn't work.
> 
> Could you ask blink-dev@ to get A+ for copying file?

I did copy files[1] on 2015.
[1] http://crrev.com/1235833002: Copy Caret.{cpp.h} to
DragCaretController.{cpp.h}

[joone, 2017-01-27 19:30:46]

Patchset #3 (id:60001) has been deleted

[joone, 2017-01-27 19:31:50]

Patchset #3 (id:80001) has been deleted

[joone, 2017-01-27 19:33:57]

Patchset #4 (id:120001) has been deleted

[joone, 2017-01-27 19:34:08]

Patchset #3 (id:100001) has been deleted

[joone, 2017-01-27 22:15:30]

Patchset #4 (id:160001) has been deleted

[joone, 2017-01-27 22:15:38]

Patchset #3 (id:140001) has been deleted

[joone, 2017-02-06 18:29:22]

Patchset #3 (id:180001) has been deleted

[joone, 2017-02-06 18:31:35]

Hi yosin@ there seems no way to add A+. Can we land this patch?

[joone, 2017-02-06 22:15:11]

On 2017/02/06 18:31:35, joone wrote:
> Hi yosin@ there seems no way to add A+. Can we land this patch?

Discussion on blink-dev:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/A$2B%7Cso...

[yosin_UTC9, 2017-02-08 01:26:45]

lgtm

Let's see how "git blame" handles this.

[yosin_UTC9, 2017-02-08 01:26:48]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-02-08 01:27:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 02:31:13]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1486517208114970,
"parent_rev": "3cc64b8397bc68525879441dd41fa7a3082aeb83", "commit_rev":
"3f6dfe4978e72853c4debad300c97b4d3872ad89"}

[commit-bot: I haz the power, 2017-02-08 02:31:47]

Description was changed from

==========
Add EditingStyleUtilities.{cpp,h}

EditingStyle is used to deal with CSS styles in editing. but it has
many static methods to create an EditingStyle and some of the methods
don't access member variables so they can be split into
EditingStyleUtilities class.

This CL copies EditingStyle.{cpp,h} to EditingStyleUtilities.{cpp,h}
as part of refactoring EditingStyle class.

BUG=679817
TEST=n/a; no behavior changes
==========

to

==========
Add EditingStyleUtilities.{cpp,h}

EditingStyle is used to deal with CSS styles in editing. but it has
many static methods to create an EditingStyle and some of the methods
don't access member variables so they can be split into
EditingStyleUtilities class.

This CL copies EditingStyle.{cpp,h} to EditingStyleUtilities.{cpp,h}
as part of refactoring EditingStyle class.

BUG=679817
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2649613002
Cr-Commit-Position: refs/heads/master@{#448866}
Committed:
https://chromium.googlesource.com/chromium/src/+/3f6dfe4978e72853c4debad300c9...
==========

[commit-bot: I haz the power, 2017-02-08 02:31:48]

Committed patchset #3 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/3f6dfe4978e72853c4debad300c9...