DevTools: add missing check for null script in SourceMapNamesResolver

DevTools: add missing check for null script in SourceMapNamesResolver

SourceMapNamesResolver.js was missing a check due to the possibility for
SDK.DebuggerModel.Location.script() to return null.

BUG=681419
Review-Url: https://codereview.chromium.org/2649593002
Cr-Commit-Position: refs/heads/master@{#445212}
Committed: https://chromium.googlesource.com/chromium/src/+/9889b14fb43fb5faba6df832065a5d3373e76df3

[luoe, 2017-01-20 18:38:53]

Description was changed from

==========
DevTools: fix persistence step into bug

BUG=681419
==========

to

==========
DevTools: fix persistence step into bug

SourceMapNamesResolver.js was missing a check due to the possibility for
SDK.DebuggerModel.Location.script() to return null.

BUG=681419
==========

[luoe, 2017-01-20 18:38:57]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[luoe, 2017-01-20 18:39:13]

luoe@chromium.org changed reviewers:
+ dgozman@chromium.org, lushnikov@chromium.org

[luoe, 2017-01-20 18:39:14]

Please take a look

[commit-bot: I haz the power, 2017-01-20 18:39:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[luoe, 2017-01-20 18:39:55]

Description was changed from

==========
DevTools: fix persistence step into bug

SourceMapNamesResolver.js was missing a check due to the possibility for
SDK.DebuggerModel.Location.script() to return null.

BUG=681419
==========

to

==========
DevTools: add missing check for null script in SourceMapNamesResolver

SourceMapNamesResolver.js was missing a check due to the possibility for
SDK.DebuggerModel.Location.script() to return null.

BUG=681419
==========

[commit-bot: I haz the power, 2017-01-20 19:58:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 19:58:52]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-01-20 23:46:02]

lgtm. Nice fix!

[luoe, 2017-01-20 23:46:27]

The CQ bit was checked by luoe@chromium.org

[commit-bot: I haz the power, 2017-01-20 23:47:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 23:51:55]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484955987778590, "parent_rev":
"a77d1f27b7d151775ba412bd522344e060736d02", "commit_rev":
"9889b14fb43fb5faba6df832065a5d3373e76df3"}

[commit-bot: I haz the power, 2017-01-20 23:52:31]

Description was changed from

==========
DevTools: add missing check for null script in SourceMapNamesResolver

SourceMapNamesResolver.js was missing a check due to the possibility for
SDK.DebuggerModel.Location.script() to return null.

BUG=681419
==========

to

==========
DevTools: add missing check for null script in SourceMapNamesResolver

SourceMapNamesResolver.js was missing a check due to the possibility for
SDK.DebuggerModel.Location.script() to return null.

BUG=681419

Review-Url: https://codereview.chromium.org/2649593002
Cr-Commit-Position: refs/heads/master@{#445212}
Committed:
https://chromium.googlesource.com/chromium/src/+/9889b14fb43fb5faba6df832065a...
==========

[commit-bot: I haz the power, 2017-01-20 23:52:32]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9889b14fb43fb5faba6df832065a...

[lushnikov, 2017-01-23 05:23:46]

Thank you for the fix! Still, how come this was resulting in target page crash?

[luoe, 2017-01-23 19:01:18]

That part is not yet clear to me.  I'm only able to reproduce the bug on my
personal computer at home, which has a slower HDD.  Let's continue this
discussion in the bug!