Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2649573003: Revert of Move compositor InputHandler from RenderViewImpl to RenderWidget. (Closed)

Created:
3 years, 11 months ago by waffles
Modified:
3 years, 11 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org, jam, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, site-isolation-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move compositor InputHandler from RenderViewImpl to RenderWidget. (patchset #29 id:690001 of https://codereview.chromium.org/2479663002/ ) Reason for revert: Causes flaky failures of SitePerProcessInteractiveBrowserTest.SubframeKeyboardEventRouting. Original issue's description: > Move compositor InputHandler from RenderViewImpl to RenderWidget. > > At present the input handler for cross-process iframes is installed > only on the RenderViewImpl, meaning that events sent to them can only > be handled on the main thread (instead of the compositor thread). > > Note: The compositor layer tree on the RenderViewImpl for a cross- > process frame renderer is actually empty. > > This CL attaches an input handler to each RenderWidget instead, > allowing compositor-thread handling of input events for all > the frames. This is a precursor for handling GesturePinch events for > subframes. > > BUG=654917 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Review-Url: https://codereview.chromium.org/2479663002 > Cr-Commit-Position: refs/heads/master@{#445175} > Committed: https://chromium.googlesource.com/chromium/src/+/efd05aec93fad28adb8bef9674530e7bbe64766f TBR=enne@chromium.org,avi@chromium.org,dcheng@chromium.org,lfg@chromium.org,wjmaclean@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=654917 Review-Url: https://codereview.chromium.org/2649573003 Cr-Commit-Position: refs/heads/master@{#445231} Committed: https://chromium.googlesource.com/chromium/src/+/b5ac0ebfe4e03b8e1da707fa38f29550022a94ea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -381 lines) Patch
M cc/trees/layer_tree_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/input_router_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_input_event_router.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 2 chunks +2 lines, -81 lines 0 comments Download
M content/renderer/gpu/compositor_dependencies.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.h View 3 chunks +0 lines, -3 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 4 chunks +0 lines, -37 lines 0 comments Download
M content/renderer/input/input_handler_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/input/input_handler_manager.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/input/input_handler_wrapper.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/input/input_handler_wrapper.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/renderer/render_thread_impl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M content/renderer/render_view_impl.h View 6 chunks +6 lines, -8 lines 0 comments Download
M content/renderer/render_view_impl.cc View 3 chunks +20 lines, -16 lines 0 comments Download
M content/renderer/render_widget.h View 5 chunks +0 lines, -9 lines 0 comments Download
M content/renderer/render_widget.cc View 6 chunks +3 lines, -18 lines 0 comments Download
M content/test/fake_compositor_dependencies.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/fake_compositor_dependencies.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/EventHandlerRegistry.h View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp View 3 chunks +6 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 chunk +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 chunk +4 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClient.h View 1 chunk +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.h View 1 chunk +3 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 2 chunks +21 lines, -69 lines 0 comments Download
M third_party/WebKit/Source/web/WebPagePopupImpl.cpp View 1 chunk +16 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/FrameTestHelpers.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 3 chunks +7 lines, -11 lines 0 comments Download
M third_party/WebKit/public/platform/WebLayerTreeView.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
waffles
Created Revert of Move compositor InputHandler from RenderViewImpl to RenderWidget.
3 years, 11 months ago (2017-01-21 00:49:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649573003/1
3 years, 11 months ago (2017-01-21 00:49:24 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-21 00:51:01 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b5ac0ebfe4e03b8e1da707fa38f2...

Powered by Google App Engine
This is Rietveld 408576698