Do not enter Maximize Mode while docked

Do not enter Maximize Mode while docked

Update the handling of the tablet mode switch to not trigger maximize mode if
the device is currently docked.

BUG=682859
Review-Url: https://codereview.chromium.org/2649553004
Cr-Commit-Position: refs/heads/master@{#446195}
Committed: https://chromium.googlesource.com/chromium/src/+/1d03b9255a7b9ccdb4047d57e78e70e6cf1db0b8

[gwendal1, 2017-01-22 22:59:25]

gwendal@google.com changed reviewers:
+ gwendal@google.com

[gwendal1, 2017-01-22 22:59:26]

lgtm

[gwendal, 2017-01-23 20:48:30]

gwendal@chromium.org changed reviewers:
+ gwendal@chromium.org

[gwendal, 2017-01-23 20:48:31]

https://codereview.chromium.org/2649553004/diff/20001/ash/common/wm/maximize_...
File ash/common/wm/maximize_mode/maximize_mode_controller.cc (right):

https://codereview.chromium.org/2649553004/diff/20001/ash/common/wm/maximize_...
ash/common/wm/maximize_mode/maximize_mode_controller.cc:365: } else if
(tablet_mode_switch_is_on_) {
not enough: what if the use is in tent mode, and the tablet_mode_switch_is_on_
has not kicked in yet?

Ok, that's a corner case, but we should check the lid angle as well if
measurable.

[jonross, 2017-01-23 21:08:30]

https://codereview.chromium.org/2649553004/diff/20001/ash/common/wm/maximize_...
File ash/common/wm/maximize_mode/maximize_mode_controller.cc (right):

https://codereview.chromium.org/2649553004/diff/20001/ash/common/wm/maximize_...
ash/common/wm/maximize_mode/maximize_mode_controller.cc:365: } else if
(tablet_mode_switch_is_on_) {
On 2017/01/23 20:48:31, gwendal wrote:
> not enough: what if the use is in tent mode, and the tablet_mode_switch_is_on_
> has not kicked in yet?
> 
> Ok, that's a corner case, but we should check the lid angle as well if
> measurable.

With the internal display back on we will automatically go back to checking
accelerometer values. This has been how we have been handling exiting docked
mode historically.

The difference is only when tablet_mode_switch_is_on_ as we exit accelerometer
checks while that is true. So right now we wouldn't enter tablet mode.

I can update the docs here to be more explicit, and add a test for both.

[jonross, 2017-01-24 23:21:00]

jonross@chromium.org changed reviewers:
+ oshima@chromium.org

[jonross, 2017-01-24 23:21:01]

Hey Oshima,

Could you provide an owner's review for this change?

In it I update the handling of the tablet mode switch, so that it works with
docked mode.

Thanks,
Jon

[oshima, 2017-01-25 22:13:19]

lgtm

https://codereview.chromium.org/2649553004/diff/60001/ash/common/wm/maximize_...
File ash/common/wm/maximize_mode/maximize_mode_controller.cc (right):

https://codereview.chromium.org/2649553004/diff/60001/ash/common/wm/maximize_...
ash/common/wm/maximize_mode/maximize_mode_controller.cc:234: return;
optional: you may keep if you prefer that way.

if (!has_internal() || !isactive())
  return;
?

[jonross, 2017-01-26 00:58:39]

https://codereview.chromium.org/2649553004/diff/60001/ash/common/wm/maximize_...
File ash/common/wm/maximize_mode/maximize_mode_controller.cc (right):

https://codereview.chromium.org/2649553004/diff/60001/ash/common/wm/maximize_...
ash/common/wm/maximize_mode/maximize_mode_controller.cc:234: return;
On 2017/01/25 22:13:19, oshima wrote:
> optional: you may keep if you prefer that way.
> 
> if (!has_internal() || !isactive())
>   return;
> ?

Done.

[jonross, 2017-01-26 00:58:45]

The CQ bit was checked by jonross@chromium.org

[jonross, 2017-01-26 00:58:45]

The patchset sent to the CQ was uploaded after l-g-t-m from gwendal@google.com,
oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/2649553004/#ps100001
(title: ".")

[commit-bot: I haz the power, 2017-01-26 01:00:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 01:38:03]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1485392325247910,
"parent_rev": "cf18468fc7b170fdee94efffd557f17cdcd1086b", "commit_rev":
"1d03b9255a7b9ccdb4047d57e78e70e6cf1db0b8"}

[commit-bot: I haz the power, 2017-01-26 01:38:31]

Description was changed from

==========
Do not enter Maximize Mode while docked

Update the handling of the tablet mode switch to not trigger maximize mode if
the device is currently docked.

BUG=682859
==========

to

==========
Do not enter Maximize Mode while docked

Update the handling of the tablet mode switch to not trigger maximize mode if
the device is currently docked.

BUG=682859

Review-Url: https://codereview.chromium.org/2649553004
Cr-Commit-Position: refs/heads/master@{#446195}
Committed:
https://chromium.googlesource.com/chromium/src/+/1d03b9255a7b9ccdb4047d57e78e...
==========

[commit-bot: I haz the power, 2017-01-26 01:38:33]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/1d03b9255a7b9ccdb4047d57e78e...