Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 2649523002: Replace ENABLE(ASSERT) leftovers with DCHECK_IS_ON(). (Closed)

Created:
3 years, 11 months ago by tkent
Modified:
3 years, 11 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace ENABLE(ASSERT) leftovers with DCHECK_IS_ON(). BUG=596760 Review-Url: https://codereview.chromium.org/2649523002 Cr-Commit-Position: refs/heads/master@{#445020} Committed: https://chromium.googlesource.com/chromium/src/+/95e14f9bd10025985df163114945a270e2d69bc3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/layout/FloatingObjects.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
tkent
yosin@, would you review this please?
3 years, 11 months ago (2017-01-20 06:38:33 UTC) #4
yosin_UTC9
lgtm Thanks for quick work! My patch also this pattern and I pick up my ...
3 years, 11 months ago (2017-01-20 06:49:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649523002/1
3 years, 11 months ago (2017-01-20 06:49:49 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 08:56:25 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/95e14f9bd10025985df163114945...

Powered by Google App Engine
This is Rietveld 408576698