bluetooth: Add control for reading/writing of descriptor values to internals page.

bluetooth: Add control for reading/writing of descriptor values to internals page.

Adds ValueControl to descriptor list and modifies it to handle reading
    and writing descriptor and characteristic values.

BUG=651282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2649473002
Cr-Commit-Position: refs/heads/master@{#446586}
Committed: https://chromium.googlesource.com/chromium/src/+/c83a4da2853656166529cab549db1d517a54523a

[mbrunson, 2017-01-20 02:14:01]

Description was changed from

==========
bluetooth: Add control for reading/writing of descriptor values to internals
page.

Adds ValueControl to descriptor list.
Updates ValueControl to support reading/writing of descriptor values using
    provided permissions.

BUG=651282
==========

to

==========
bluetooth: Add control for reading/writing of descriptor values to internals
page.

Adds ValueControl to descriptor list.
Updates ValueControl to support reading/writing of descriptor values using
    provided permissions.

BUG=651282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[mbrunson, 2017-01-25 04:34:36]

Description was changed from

==========
bluetooth: Add control for reading/writing of descriptor values to internals
page.

Adds ValueControl to descriptor list.
Updates ValueControl to support reading/writing of descriptor values using
    provided permissions.

BUG=651282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
bluetooth: Add control for reading/writing of descriptor values to internals
page.

Adds ValueControl to descriptor list and modifies it to handle reading
    and writing descriptor and characteristic values.

BUG=651282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[mbrunson, 2017-01-25 04:34:36]

mbrunson@chromium.org changed reviewers:
+ ortuno@chromium.org, scheib@chromium.org

[scheib, 2017-01-25 05:03:19]

LGTM

[mbrunson, 2017-01-25 22:52:18]

The CQ bit was checked by mbrunson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 22:53:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mbrunson, 2017-01-25 22:54:22]

mbrunson@chromium.org changed reviewers:
+ dpapad@chromium.org, tsepez@chromium.org

[mbrunson, 2017-01-25 22:54:22]

OWNERS review, please:

tsepez:
  device/bluetooth/public/interfaces/device.mojom

dpapad:
  chrome/browser/resources/bluetooth_internals/characteristic_list.js
  chrome/browser/resources/bluetooth_internals/descriptor_list.js
  chrome/browser/resources/bluetooth_internals/value_control.js

[Tom Sepez, 2017-01-25 23:01:53]

mojom LGTM

[dpapad, 2017-01-26 00:28:52]

webui LGTM

https://codereview.chromium.org/2649473002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/bluetooth_internals/descriptor_list.js (right):

https://codereview.chromium.org/2649473002/diff/80001/chrome/browser/resource...
chrome/browser/resources/bluetooth_internals/descriptor_list.js:137: 
Nit: Remove unnecessary blank line.

[commit-bot: I haz the power, 2017-01-26 02:24:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 02:24:38]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[mbrunson, 2017-01-26 19:21:19]

https://codereview.chromium.org/2649473002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/bluetooth_internals/descriptor_list.js (right):

https://codereview.chromium.org/2649473002/diff/80001/chrome/browser/resource...
chrome/browser/resources/bluetooth_internals/descriptor_list.js:137: 
On 2017/01/26 00:28:51, dpapad wrote:
> Nit: Remove unnecessary blank line.

Done.

[mbrunson, 2017-01-27 01:25:07]

The CQ bit was checked by mbrunson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 01:26:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 03:55:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 03:55:54]

Dry run: This issue passed the CQ dry run.

[mbrunson, 2017-01-27 03:59:08]

The CQ bit was checked by mbrunson@chromium.org

[mbrunson, 2017-01-27 03:59:08]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org,
tsepez@chromium.org, dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2649473002/#ps120001
(title: "Merge upstream")

[commit-bot: I haz the power, 2017-01-27 03:59:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 04:09:18]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1485489548517050,
"parent_rev": "eedd7c15d7970a5b81a2e6060c8f18d5242885a4", "commit_rev":
"c83a4da2853656166529cab549db1d517a54523a"}

[commit-bot: I haz the power, 2017-01-27 04:10:12]

Description was changed from

==========
bluetooth: Add control for reading/writing of descriptor values to internals
page.

Adds ValueControl to descriptor list and modifies it to handle reading
    and writing descriptor and characteristic values.

BUG=651282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
bluetooth: Add control for reading/writing of descriptor values to internals
page.

Adds ValueControl to descriptor list and modifies it to handle reading
    and writing descriptor and characteristic values.

BUG=651282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2649473002
Cr-Commit-Position: refs/heads/master@{#446586}
Committed:
https://chromium.googlesource.com/chromium/src/+/c83a4da2853656166529cab549db...
==========

[commit-bot: I haz the power, 2017-01-27 04:10:14]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/c83a4da2853656166529cab549db...