Make WebSocket available again in service workers

Make WebSocket available again in service workers

The patch https://codereview.chromium.org/2284473002/ was basically a
refactoring change, but it also included a change that it started using
the InterfaceProvider instance of the LocalFrame of the associated
Document if any. However, in a service worker, the LocalFrame returns
the empty provider obtained by calling
InterfaceProvider::getEmptyInterfaceProvider(). This is because the
WebEmbeddedWorkerImpl used for service workers doesn't override
the WebFrameClient::interfaceProvider() method which returns nullptr by
default while one on the WebSharedWorkerImpl and RenderFrameImpl
returns an effective InterfaceProvider instance.

This patch fixes the issue by changing the code to use the
InterfaceProvider of the LocalFrame only when it's not the empty
provider.

R=falken@chromium.org
TBR=yhirano@chromium.org
BUG=671588
Review-Url: https://codereview.chromium.org/2564493002
Cr-Commit-Position: refs/heads/master@{#437406}
(cherry picked from commit dd3b58a1f0073215d58bcb8dc216b89e546bc9f7)

Review-Url: https://codereview.chromium.org/2649463003 .
Cr-Commit-Position: refs/branch-heads/2924@{#815}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Committed: https://chromium.googlesource.com/chromium/src/+/31c0d697c6d885cee1084c1c30e4f04d2e32e36a

[tyoshino (SeeGerritForStatus), 2017-01-20 06:36:00]

Description was changed from

==========
Make WebSocket available again in service workers

The patch https://codereview.chromium.org/2284473002/ was basically a
refactoring change, but it also included a change that it started using
the InterfaceProvider instance of the LocalFrame of the associated
Document if any. However, in a service worker, the LocalFrame returns
the empty provider obtained by calling
InterfaceProvider::getEmptyInterfaceProvider(). This is because the
WebEmbeddedWorkerImpl used for service workers doesn't override
the WebFrameClient::interfaceProvider() method which returns nullptr by
default while one on the WebSharedWorkerImpl and RenderFrameImpl
returns an effective InterfaceProvider instance.

This patch fixes the issue by changing the code to use the
InterfaceProvider of the LocalFrame only when it's not the empty
provider.

R=falken@chromium.org
TBR=yhirano@chromium.org
BUG=671588

Review-Url: https://codereview.chromium.org/2564493002
Cr-Commit-Position: refs/heads/master@{#437406}
(cherry picked from commit dd3b58a1f0073215d58bcb8dc216b89e546bc9f7)
==========

to

==========
Make WebSocket available again in service workers

The patch https://codereview.chromium.org/2284473002/ was basically a
refactoring change, but it also included a change that it started using
the InterfaceProvider instance of the LocalFrame of the associated
Document if any. However, in a service worker, the LocalFrame returns
the empty provider obtained by calling
InterfaceProvider::getEmptyInterfaceProvider(). This is because the
WebEmbeddedWorkerImpl used for service workers doesn't override
the WebFrameClient::interfaceProvider() method which returns nullptr by
default while one on the WebSharedWorkerImpl and RenderFrameImpl
returns an effective InterfaceProvider instance.

This patch fixes the issue by changing the code to use the
InterfaceProvider of the LocalFrame only when it's not the empty
provider.

R=falken@chromium.org
TBR=yhirano@chromium.org
BUG=671588

Review-Url: https://codereview.chromium.org/2564493002
Cr-Commit-Position: refs/heads/master@{#437406}
(cherry picked from commit dd3b58a1f0073215d58bcb8dc216b89e546bc9f7)

Review-Url: https://codereview.chromium.org/2649463003 .
Cr-Commit-Position: refs/branch-heads/2924@{#815}
Cr-Branched-From:
3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Committed:
https://chromium.googlesource.com/chromium/src/+/31c0d697c6d885cee1084c1c30e4...
==========

[tyoshino (SeeGerritForStatus), 2017-01-20 06:36:05]

Committed patchset #1 (id:1) manually as
31c0d697c6d885cee1084c1c30e4f04d2e32e36a.

[falken, 2017-01-23 03:12:25]

lgtm