When killing wptserve, use Executive.interrupt on non-Windows platforms.

When killing wptserve, use Executive.interrupt on non-Windows platforms.

Before http://crrev.com/2624093003, the test runner would hang in a busy
loop while trying to kill wptserve.

After that CL, though, when running run-webkit-tests locally on Linux,
wptserve wouldn't be effectively killed before the next run.

This CL is meant to make it so that it behaves more like it did before
(using interrupt instead of kill for non-Windows platforms), but still
only tries to kill wptserve for 20 seconds, with 1-second sleeps between
attempts.

I tried locally to see what would happen if I undid the change in
http://crrev.com/2624093003 but only changed _stop_running_server to
use kill_process on all platforms (not just Windows), and confirmed that
this apparently doesn't kill the process properly on my workstation.

BUG=669802, 682711
Review-Url: https://codereview.chromium.org/2649433002
Cr-Commit-Position: refs/heads/master@{#444933}
Committed: https://chromium.googlesource.com/chromium/src/+/896b0f4ea756385f66de7b31c52fccf728a02cb6

[qyearsley, 2017-01-19 22:16:45]

qyearsley@chromium.org changed reviewers:
+ dpranke@chromium.org, tkent@chromium.org

[tkent, 2017-01-19 23:04:33]

lgtm

[qyearsley, 2017-01-19 23:08:10]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2017-01-19 23:08:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[qyearsley, 2017-01-20 00:57:22]

The CQ bit was unchecked by qyearsley@chromium.org

[qyearsley, 2017-01-20 00:57:41]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2017-01-20 00:58:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 01:46:21]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484873861873210, "parent_rev":
"5fd58b97f3aaaa23c1dd4e36a63b8c1fbb41d1b9", "commit_rev":
"896b0f4ea756385f66de7b31c52fccf728a02cb6"}

[commit-bot: I haz the power, 2017-01-20 01:46:49]

Description was changed from

==========
When killing wptserve, use Executive.interrupt on non-Windows platforms.

Before http://crrev.com/2624093003, the test runner would hang in a busy
loop while trying to kill wptserve.

After that CL, though, when running run-webkit-tests locally on Linux,
wptserve wouldn't be effectively killed before the next run.

This CL is meant to make it so that it behaves more like it did before
(using interrupt instead of kill for non-Windows platforms), but still
only tries to kill wptserve for 20 seconds, with 1-second sleeps between
attempts.

I tried locally to see what would happen if I undid the change in
http://crrev.com/2624093003 but only changed _stop_running_server to
use kill_process on all platforms (not just Windows), and confirmed that
this apparently doesn't kill the process properly on my workstation.

BUG=669802,682711
==========

to

==========
When killing wptserve, use Executive.interrupt on non-Windows platforms.

Before http://crrev.com/2624093003, the test runner would hang in a busy
loop while trying to kill wptserve.

After that CL, though, when running run-webkit-tests locally on Linux,
wptserve wouldn't be effectively killed before the next run.

This CL is meant to make it so that it behaves more like it did before
(using interrupt instead of kill for non-Windows platforms), but still
only tries to kill wptserve for 20 seconds, with 1-second sleeps between
attempts.

I tried locally to see what would happen if I undid the change in
http://crrev.com/2624093003 but only changed _stop_running_server to
use kill_process on all platforms (not just Windows), and confirmed that
this apparently doesn't kill the process properly on my workstation.

BUG=669802,682711

Review-Url: https://codereview.chromium.org/2649433002
Cr-Commit-Position: refs/heads/master@{#444933}
Committed:
https://chromium.googlesource.com/chromium/src/+/896b0f4ea756385f66de7b31c52f...
==========

[commit-bot: I haz the power, 2017-01-20 01:46:51]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/896b0f4ea756385f66de7b31c52f...