Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: runtime/vm/disassembler_arm64.cc

Issue 264943007: Adds double load and store to arm64. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/constants_arm64.h ('k') | runtime/vm/simulator_arm64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/disassembler_arm64.cc
===================================================================
--- runtime/vm/disassembler_arm64.cc (revision 35661)
+++ runtime/vm/disassembler_arm64.cc (working copy)
@@ -312,6 +312,10 @@
int reg = instr->VnField();
PrintVRegister(reg);
return 2;
+ } else if (format[1] == 't') {
+ int reg = instr->VtField();
+ PrintVRegister(reg);
+ return 2;
}
UNREACHABLE();
return -1;
@@ -554,14 +558,28 @@
void ARM64Decoder::DecodeLoadStoreReg(Instr* instr) {
- if (instr->Bits(25, 2) != 0) {
+ if (instr->Bit(23) != 0) {
+ // 128-bit ldr/str.
Unknown(instr);
- return;
}
- if (instr->Bit(22) == 1) {
- Format(instr, "ldr'sz 'rt, 'memop");
+ if (instr->Bit(26) == 1) {
+ if (instr->Bits(30, 2) != 3) {
+ // Only 64-bit double variant supported.
+ Unknown(instr);
+ }
+ // SIMD or FP src/dst.
+ if (instr->Bit(22) == 1) {
+ Format(instr, "fldrd 'vt, 'memop");
+ } else {
+ Format(instr, "fstrd 'vt, 'memop");
+ }
} else {
- Format(instr, "str'sz 'rt, 'memop");
+ // Integer src/dst.
+ if (instr->Bit(22) == 1) {
+ Format(instr, "ldr'sz 'rt, 'memop");
+ } else {
+ Format(instr, "str'sz 'rt, 'memop");
+ }
}
}
« no previous file with comments | « runtime/vm/constants_arm64.h ('k') | runtime/vm/simulator_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698