Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Issue 2649363003: Extract test directory owner email addresses from W3CImportExpectations. (Closed)

Created:
3 years, 11 months ago by qyearsley
Modified:
3 years, 10 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke, jeffcarp, jsbell
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extract test directory owner email addresses from W3CImportExpectations. The purpose of this CL is to improve the list of people to CC that the w3c-test-autoroller generates -- previously the list was based on a file directory_owners.json, which was generated once (from a spreadsheet) and had only a couple of (mailing list) addresses. This CL would make it so that directory owners are extracted from W3CImportExpectations. Another alternate approach would be to use W3CImportExpectations to generate a JSON file, and read that, but then that way we would have to regularly update the JSON file. BUG=684026 Review-Url: https://codereview.chromium.org/2649363003 Cr-Commit-Position: refs/heads/master@{#446157} Committed: https://chromium.googlesource.com/chromium/src/+/4edc8aac446bd6bc319b9430ed1bed30391f1ff1

Patch Set 1 #

Total comments: 2

Patch Set 2 : Handle spaces after commas; remove now-unused script. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -1731 lines) Patch
M third_party/WebKit/LayoutTests/W3CImportExpectations View 3 chunks +6 lines, -4 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/generate-w3c-directory-owner-json View 1 1 chunk +0 lines, -52 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py View 1 4 chunks +13 lines, -14 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners.json View 1 chunk +0 lines, -1661 lines 0 comments Download
A third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor.py View 1 1 chunk +75 lines, -0 lines 0 comments Download
A third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor_unittest.py View 1 1 chunk +75 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
qyearsley
3 years, 11 months ago (2017-01-25 00:36:39 UTC) #5
tkent
lgtm https://codereview.chromium.org/2649363003/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor_unittest.py File third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor_unittest.py (right): https://codereview.chromium.org/2649363003/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor_unittest.py#newcode57 third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor_unittest.py:57: self.assertEqual(self.extractor.extract_owners('## Owners: a@x.com,b@x.com'), ['a@x.com', 'b@x.com']) Add a testcase ...
3 years, 11 months ago (2017-01-25 01:02:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649363003/20001
3 years, 10 months ago (2017-01-25 21:11:01 UTC) #12
qyearsley
https://codereview.chromium.org/2649363003/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor_unittest.py File third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor_unittest.py (right): https://codereview.chromium.org/2649363003/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor_unittest.py#newcode57 third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor_unittest.py:57: self.assertEqual(self.extractor.extract_owners('## Owners: a@x.com,b@x.com'), ['a@x.com', 'b@x.com']) On 2017/01/25 at 01:02:13, ...
3 years, 10 months ago (2017-01-25 23:01:25 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-01-25 23:11:20 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4edc8aac446bd6bc319b9430ed1b...

Powered by Google App Engine
This is Rietveld 408576698