Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2649343002: Roll WebGL 9b0c9de..3c655cc (Closed)

Created:
3 years, 11 months ago by qiankun
Modified:
3 years, 11 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll WebGL 9b0c9de..3c655cc https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/9b0c9de..3c655cc BUG=603906, 666384, 678382, 673929, 682190, 684399 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2649343002 Cr-Commit-Position: refs/heads/master@{#445758} Committed: https://chromium.googlesource.com/chromium/src/+/079ae727092a8011d34ddc6cb3feeb7422bc4a6a

Patch Set 1 #

Patch Set 2 : update expectations #

Patch Set 3 : update expectations #

Patch Set 4 : remove flaky failure after webgl cts roll #

Patch Set 5 : update expectations #

Patch Set 6 : update expectations #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 2 3 4 5 2 chunks +7 lines, -4 lines 3 comments Download
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 1 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
qiankun
PTAL.
3 years, 11 months ago (2017-01-24 15:55:45 UTC) #4
Zhenyao Mo
lgtm https://codereview.chromium.org/2649343002/diff/100001/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right): https://codereview.chromium.org/2649343002/diff/100001/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py#newcode689 content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:689: ['linux', 'nvidia'], bug=684399) Are these flaky or consistently ...
3 years, 11 months ago (2017-01-24 16:47:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649343002/100001
3 years, 11 months ago (2017-01-24 16:47:28 UTC) #7
commit-bot: I haz the power
Committed patchset #6 (id:100001) as https://chromium.googlesource.com/chromium/src/+/079ae727092a8011d34ddc6cb3feeb7422bc4a6a
3 years, 11 months ago (2017-01-24 18:06:33 UTC) #10
qiankun
3 years, 11 months ago (2017-01-25 02:27:47 UTC) #11
Message was sent while issue was closed. 
https://codereview.chromium.org/2649343002/diff/100001/content/test/gpu/gpu_t...
File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (left):

https://codereview.chromium.org/2649343002/diff/100001/content/test/gpu/gpu_t...
content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:685:
self.Fail('conformance2/textures/image_data/tex-2d-rg32f-rg-float.html',
This failure disappeared in this roll.

https://codereview.chromium.org/2649343002/diff/100001/content/test/gpu/gpu_t...
File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right):

https://codereview.chromium.org/2649343002/diff/100001/content/test/gpu/gpu_t...
content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:689: ['linux',
'nvidia'], bug=684399)
On 2017/01/24 16:47:10, Zhenyao Mo wrote:
> Are these flaky or consistently failing?

They failed always in this roll.

Powered by Google App Engine
This is Rietveld 408576698