Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 2649323007: Expose another method to parse just CSSValue into CSSStyleValueVector in StyleValueFactory (Closed)

Created:
3 years, 11 months ago by renjieliu1
Modified:
3 years, 10 months ago
Reviewers:
meade_UTC10, skobes
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose a method to convert a CSSValue into a CSSStyleValueVector when you don't have a CSSPropertyID BUG=672647 Review-Url: https://codereview.chromium.org/2649323007 Cr-Commit-Position: refs/heads/master@{#447175} Committed: https://chromium.googlesource.com/chromium/src/+/9e3e9494dcbd592e5ca4e1d3f058d797b0343dad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M third_party/WebKit/Source/core/css/cssom/StyleValueFactory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
renjieliu1
3 years, 11 months ago (2017-01-25 06:20:06 UTC) #3
meade_UTC10
lgtm Please update the CL description explaining what the method does, something like "Expose a ...
3 years, 11 months ago (2017-01-27 06:10:59 UTC) #4
renjieliu1
On 2017/01/27 06:10:59, Eddy wrote: > lgtm > > Please update the CL description explaining ...
3 years, 10 months ago (2017-01-28 23:54:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649323007/1
3 years, 10 months ago (2017-01-31 00:03:30 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/353542)
3 years, 10 months ago (2017-01-31 00:13:59 UTC) #10
renjieliu1
3 years, 10 months ago (2017-01-31 01:02:59 UTC) #12
skobes
rs lgtm
3 years, 10 months ago (2017-01-31 01:07:27 UTC) #13
renjieliu1
On 2017/01/31 01:07:27, skobes wrote: > rs lgtm thank you! :D
3 years, 10 months ago (2017-01-31 01:19:10 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649323007/1
3 years, 10 months ago (2017-01-31 01:19:52 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 03:15:38 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9e3e9494dcbd592e5ca4e1d3f058...

Powered by Google App Engine
This is Rietveld 408576698