Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1718)

Issue 2649323006: Change the Bluetooth chooser buttons order to be Cancel/Pair on MacOS (Closed)

Created:
3 years, 11 months ago by juncai
Modified:
3 years, 11 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change the Bluetooth chooser buttons order to be Cancel/Pair on MacOS This CL changes the Bluetooth chooser buttons order to be Cancel/Pair to make them consistent with other dialog buttons in Chrome. I uploaded a screenshot on the issue page. BUG=684479 Review-Url: https://codereview.chromium.org/2649323006 Cr-Commit-Position: refs/heads/master@{#445853} Committed: https://chromium.googlesource.com/chromium/src/+/0f5c7c7e52c0983aaa111f7a6ccc7003ad737fad

Patch Set 1 : change the Bluetooth chooser buttons order to be Cancel/Pair on MacOS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -20 lines) Patch
M chrome/browser/ui/cocoa/device_chooser_content_view_cocoa.mm View 4 chunks +21 lines, -20 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
juncai
Please take a look.
3 years, 11 months ago (2017-01-24 22:32:51 UTC) #4
Robert Sesek
LGTM
3 years, 11 months ago (2017-01-24 22:36:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649323006/1
3 years, 11 months ago (2017-01-24 23:15:10 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 23:24:26 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0f5c7c7e52c0983aaa111f7a6ccc...

Powered by Google App Engine
This is Rietveld 408576698