third_party/WebKit/Source/modules/eventsource/EventSource.cpp - Issue 2649323005: Cleanly detach XHR and other pending loader clients from Inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/eventsource/EventSource.cpp

Issue 2649323005: Cleanly detach XHR and other pending loader clients from Inspector. (Closed)

Patch Set: clarifications Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/eventsource/EventSource.cpp

diff --git a/third_party/WebKit/Source/modules/eventsource/EventSource.cpp b/third_party/WebKit/Source/modules/eventsource/EventSource.cpp

index 55659cda1f1db9b7da2d066761ce1bc2c3454f19..a29853af09bde5477685ad3ee148f544cf9babd1 100644

--- a/third_party/WebKit/Source/modules/eventsource/EventSource.cpp

+++ b/third_party/WebKit/Source/modules/eventsource/EventSource.cpp

@@ -122,6 +122,10 @@ EventSource::~EventSource() {

DCHECK(!m_loader);

}

+void EventSource::dispose() {

+ InspectorInstrumentation::detachClientRequest(getExecutionContext(), this);

void EventSource::scheduleInitialConnect() {

DCHECK_EQ(kConnecting, m_state);

DCHECK(!m_loader);