Cleanly detach XHR and other pending loader clients from Inspector.

third_party/WebKit/Source/modules/eventsource/EventSource.cpp

 /*
  * Copyright (C) 2009, 2012 Ericsson AB. All rights reserved.
  * Copyright (C) 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2011, Code Aurora Forum. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above copyright
@@ skipping 104 matching lines @@
 
   source->scheduleInitialConnect();
   return source;
 }
 
 EventSource::~EventSource() {
   DCHECK_EQ(kClosed, m_state);
   DCHECK(!m_loader);
 }
 
+void EventSource::dispose() {
+  InspectorInstrumentation::detachClientRequest(getExecutionContext(), this);
+}
+
 void EventSource::scheduleInitialConnect() {
   DCHECK_EQ(kConnecting, m_state);
   DCHECK(!m_loader);
 
   m_connectTimer.startOneShot(0, BLINK_FROM_HERE);
 }
 
 void EventSource::connect() {
   DCHECK_EQ(kConnecting, m_state);
   DCHECK(!m_loader);
@@ skipping 227 matching lines @@
 void EventSource::abortConnectionAttempt() {
   DCHECK_EQ(kConnecting, m_state);
 
   m_loader = nullptr;
   m_state = kClosed;
   networkRequestEnded();
 
   dispatchEvent(Event::create(EventTypeNames::error));
 }
 
 void EventSource::contextDestroyed(ExecutionContext*) {

[yhirano, 2017/01/27 08:58:44]

InspectorInstrumentation::detachClientRequest(executionContext, this) needed?

[sof, 2017/01/27 09:09:40]

The cancellation happening during close() ought to handle the unregistration wrt
Inspector, but might as make it clear and do it early.

   close();
 }
 
 bool EventSource::hasPendingActivity() const {
   return m_state != kClosed;
 }
 
 DEFINE_TRACE(EventSource) {
   visitor->trace(m_parser);
   visitor->trace(m_loader);
   EventTargetWithInlineData::trace(visitor);
   ContextLifecycleObserver::trace(visitor);
   EventSourceParser::Client::trace(visitor);
 }
 
 }  // namespace blink