Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Issue 2649313005: Add flag to ignore images by their MD5 digest (Closed)

Created:
3 years, 11 months ago by stephana
Modified:
3 years, 11 months ago
Reviewers:
dsinclair, borenet, weili
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Removed debug statement #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -8 lines) Patch
M testing/tools/gold.py View 1 4 chunks +23 lines, -7 lines 0 comments Download
M testing/tools/test_runner.py View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
stephana
3 years, 11 months ago (2017-01-25 18:50:33 UTC) #3
borenet
Looks fine to me but I'm not an owner of this code.
3 years, 11 months ago (2017-01-25 19:53:36 UTC) #4
dsinclair
lgtm
3 years, 11 months ago (2017-01-26 19:58:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649313005/20001
3 years, 11 months ago (2017-01-26 21:56:05 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 23:18:58 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/d532036fbb0efa4687f89598ff37518e3825...

Powered by Google App Engine
This is Rietveld 408576698