DevTools: restore shortcuts to switch devtool panel left/right

DevTools: restore shortcuts to switch devtool panel left/right

BUG=683140
Review-Url: https://codereview.chromium.org/2649263003
Cr-Commit-Position: refs/heads/master@{#445638}
Committed: https://chromium.googlesource.com/chromium/src/+/44fadca5234816d4defc7380bf7ae8c2376494f6

[pfeldman, 2017-01-23 22:43:08]

pfeldman@chromium.org changed reviewers:
+ caseq@chromium.org

[caseq, 2017-01-23 22:48:27]

https://codereview.chromium.org/2649263003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/main/Main.js (left):

https://codereview.chromium.org/2649263003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/main/Main.js:338:
shortcut.makeDescriptor('[', shortcut.Modifiers.CtrlOrMeta |
shortcut.Modifiers.Alt),
Let's mention this in the change description.

https://codereview.chromium.org/2649263003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js (right):

https://codereview.chromium.org/2649263003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js:256: if
(event.key === '[') {
else if, or return from previous.

https://codereview.chromium.org/2649263003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js:261: if
(event.key === ']') {
ditto.

https://codereview.chromium.org/2649263003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js (right):

https://codereview.chromium.org/2649263003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js:338: if
(this._tabs[i] === this._currentTab) {
this._tabs.indexOf(this._currentTab)

https://codereview.chromium.org/2649263003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js:339: var nextIndex
= (i + 1) % this._tabs.length;
let's extract this to a parameter.

[caseq, 2017-01-24 00:50:44]

lgtm

[pfeldman, 2017-01-24 00:51:59]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2017-01-24 00:52:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 04:06:51]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485219119597060,
"parent_rev": "aca9b80002857d21495eedb9342201e21f21950b", "commit_rev":
"44fadca5234816d4defc7380bf7ae8c2376494f6"}

[commit-bot: I haz the power, 2017-01-24 04:08:01]

Description was changed from

==========
DevTools: restore shortcuts to switch devtool panel left/right

BUG=683140
==========

to

==========
DevTools: restore shortcuts to switch devtool panel left/right

BUG=683140

Review-Url: https://codereview.chromium.org/2649263003
Cr-Commit-Position: refs/heads/master@{#445638}
Committed:
https://chromium.googlesource.com/chromium/src/+/44fadca5234816d4defc7380bf7a...
==========

[commit-bot: I haz the power, 2017-01-24 04:08:02]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/44fadca5234816d4defc7380bf7a...