Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2649263003: DevTools: restore shortcuts to switch devtool panel left/right (Closed)

Created:
3 years, 11 months ago by pfeldman
Modified:
3 years, 11 months ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: restore shortcuts to switch devtool panel left/right BUG=683140 Review-Url: https://codereview.chromium.org/2649263003 Cr-Commit-Position: refs/heads/master@{#445638} Committed: https://chromium.googlesource.com/chromium/src/+/44fadca5234816d4defc7380bf7ae8c2376494f6

Patch Set 1 #

Total comments: 5

Patch Set 2 : made selectNext/Prev read nicer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -8 lines) Patch
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js View 2 chunks +15 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
pfeldman
3 years, 11 months ago (2017-01-23 22:43:09 UTC) #2
caseq
https://codereview.chromium.org/2649263003/diff/1/third_party/WebKit/Source/devtools/front_end/main/Main.js File third_party/WebKit/Source/devtools/front_end/main/Main.js (left): https://codereview.chromium.org/2649263003/diff/1/third_party/WebKit/Source/devtools/front_end/main/Main.js#oldcode338 third_party/WebKit/Source/devtools/front_end/main/Main.js:338: shortcut.makeDescriptor('[', shortcut.Modifiers.CtrlOrMeta | shortcut.Modifiers.Alt), Let's mention this in the ...
3 years, 11 months ago (2017-01-23 22:48:27 UTC) #3
caseq
lgtm
3 years, 11 months ago (2017-01-24 00:50:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649263003/20001
3 years, 11 months ago (2017-01-24 00:52:53 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 04:08:02 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/44fadca5234816d4defc7380bf7a...

Powered by Google App Engine
This is Rietveld 408576698