Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 2649233008: [Accessibility] Remove "Edit Box" from CCT urlbar's content description (Closed)

Created:
3 years, 11 months ago by Ian Wen
Modified:
3 years, 11 months ago
Reviewers:
Ted C
CC:
chromium-reviews, jdonnelly+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Accessibility] Remove "Edit Box" from CCT urlbar's content description CCT urlbar is a EditText, and the built-in content description is "Edit box, ...". This is confusing for CCT because the urlbar is never editable. This CL forces UrlBar to use TextView's accessibility logic, if it is disabled. BUG=636988 Review-Url: https://codereview.chromium.org/2649233008 Cr-Commit-Position: refs/heads/master@{#446209} Committed: https://chromium.googlesource.com/chromium/src/+/f8075d747ec7e756142e7cd57494226b3572af77

Patch Set 1 #

Patch Set 2 : [Accessibility] Remove "Edit Box" from CCT urlbar's content description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java View 1 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Ian Wen
PTAL
3 years, 11 months ago (2017-01-26 00:40:24 UTC) #2
Ted C
lgtm
3 years, 11 months ago (2017-01-26 00:43:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649233008/20001
3 years, 11 months ago (2017-01-26 00:46:37 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 02:23:27 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f8075d747ec7e756142e7cd57494...

Powered by Google App Engine
This is Rietveld 408576698