Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 264923002: expose ConvertRadiusToSigma to aid clients in the API transition to sigma (Closed)

Created:
6 years, 7 months ago by reed1
Modified:
6 years, 7 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

expose ConvertRadiusToSigma to aid clients in the API transition to sigma NOTRY=True Committed: http://code.google.com/p/skia/source/detail?r=14501

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M include/effects/SkBlurMaskFilter.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
reed1
6 years, 7 months ago (2014-05-01 15:00:13 UTC) #1
f(malita)
LGTM I was about to do the same, as I just ran into this problem ...
6 years, 7 months ago (2014-05-01 15:05:22 UTC) #2
robertphillips
lgtm
6 years, 7 months ago (2014-05-01 15:06:46 UTC) #3
reed1
The CQ bit was checked by reed@google.com
6 years, 7 months ago (2014-05-01 15:07:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/264923002/1
6 years, 7 months ago (2014-05-01 15:08:06 UTC) #5
reed1
I'm hacking on a chrome CL that will use this. Will share soon...
6 years, 7 months ago (2014-05-01 15:08:17 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-01 15:18:34 UTC) #7
commit-bot: I haz the power
Retried try job too often on Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Nexus7-Trybot for step(s) BuildBench, BuildEverything, BuildGm, BuildSkiaLib, BuildTests, BuildTools ...
6 years, 7 months ago (2014-05-01 15:18:35 UTC) #8
reed1
The CQ bit was checked by reed@google.com
6 years, 7 months ago (2014-05-01 15:24:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/264923002/1
6 years, 7 months ago (2014-05-01 15:24:50 UTC) #10
commit-bot: I haz the power
Change committed as 14501
6 years, 7 months ago (2014-05-01 15:24:57 UTC) #11
reed1
eric, what is up with the CQ message?
6 years, 7 months ago (2014-05-01 15:25:02 UTC) #12
borenet
6 years, 7 months ago (2014-05-01 15:32:06 UTC) #13
Message was sent while issue was closed.
On 2014/05/01 15:25:02, reed1 wrote:
> eric, what is up with the CQ message?

Ravi is composing an email to the group, but it's a problem with the new CQ bot.
 I'm going to remove it for now.

Powered by Google App Engine
This is Rietveld 408576698