Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2649173002: [Media>UI] Don't scale the icon if it's smaller than the ideal size (Closed)

Created:
3 years, 11 months ago by Zhiqiang Zhang (Slow)
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Media>UI] Don't scale the icon if it's smaller than the ideal size Previously we scale favicons or media artwork images to the ideal size regardless of their original size. This increases the memory usage as we create another copy of the original image and the size will also be increased if the original image size is smaller than the ideal size. In this CL, if the original image size is smaller than the ideal size, we will reuse the original image and won't scale it anymore. BUG=682701 Review-Url: https://codereview.chromium.org/2641133004 Cr-Commit-Position: refs/heads/master@{#445147} (cherry picked from commit c3a579962e733b26ef12f564732260844d558a56) Review-Url: https://codereview.chromium.org/2649173002 . Cr-Commit-Position: refs/branch-heads/2987@{#27} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/3c4aff3e70f102ba1f911d060e3c554ac8812f17

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java View 2 chunks +8 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Zhiqiang Zhang (Slow)
3 years, 11 months ago (2017-01-23 16:49:00 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3c4aff3e70f102ba1f911d060e3c554ac8812f17.

Powered by Google App Engine
This is Rietveld 408576698