Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 2649163004: [wasm] JSAPI conformance: instance.exports has null prototype. (Closed)

Created:
3 years, 11 months ago by Mircea Trofin
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] JSAPI conformance: instance.exports has null prototype. BUG=v8:5885 Review-Url: https://codereview.chromium.org/2649163004 Cr-Commit-Position: refs/heads/master@{#42636} Committed: https://chromium.googlesource.com/v8/v8/+/777057763cd9fba6a429c578edb9f8e4e8491467

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M src/factory.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/factory.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/wasm/wasm-module.cc View 1 chunk +1 line, -4 lines 0 comments Download
M test/mjsunit/wasm/js-api.js View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Mircea Trofin
3 years, 11 months ago (2017-01-24 17:25:46 UTC) #5
rossberg
lgtm
3 years, 11 months ago (2017-01-24 17:29:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649163004/1
3 years, 11 months ago (2017-01-24 17:45:31 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_chromium_gn_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/builds/31738)
3 years, 11 months ago (2017-01-24 17:53:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649163004/1
3 years, 11 months ago (2017-01-24 18:50:23 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 19:00:43 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/777057763cd9fba6a429c578edb9f8e4e84...

Powered by Google App Engine
This is Rietveld 408576698