Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2649163002: clang tot: Disable -Wuser-defined-warnings (Closed)

Created:
3 years, 11 months ago by Nico
Modified:
3 years, 11 months ago
Reviewers:
hans
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang tot: Disable -Wuser-defined-warnings BUG=683349 TBR=hans Review-Url: https://codereview.chromium.org/2649163002 Cr-Commit-Position: refs/heads/master@{#445401} Committed: https://chromium.googlesource.com/chromium/src/+/59c02c3aa8f983c2adecb654bd71e2ada5fb4d8e

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +3 lines, -0 lines 2 comments Download

Messages

Total messages: 11 (6 generated)
Nico
3 years, 11 months ago (2017-01-23 16:39:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649163002/1
3 years, 11 months ago (2017-01-23 16:39:53 UTC) #6
hans
lgtm https://codereview.chromium.org/2649163002/diff/1/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): https://codereview.chromium.org/2649163002/diff/1/build/config/compiler/BUILD.gn#newcode1086 build/config/compiler/BUILD.gn:1086: # TODO(thakis ): https://crbug.com/683349 nit: there's an extra ...
3 years, 11 months ago (2017-01-23 16:58:39 UTC) #7
Nico
https://codereview.chromium.org/2649163002/diff/1/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): https://codereview.chromium.org/2649163002/diff/1/build/config/compiler/BUILD.gn#newcode1086 build/config/compiler/BUILD.gn:1086: # TODO(thakis ): https://crbug.com/683349 On 2017/01/23 16:58:39, hans wrote: ...
3 years, 11 months ago (2017-01-23 17:10:59 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 17:46:35 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/59c02c3aa8f983c2adecb654bd71...

Powered by Google App Engine
This is Rietveld 408576698