Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2649133010: [foozzie] Support multi-architecture builds (Closed)

Created:
3 years, 11 months ago by Michael Achenbach
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[foozzie] Support multi-architecture builds This adds optional multi-architecture builds, allowing to compile x86 and x64 in one build. The correctness fuzzer can be configured to compare the two executables, e.g. to compare x86 to x64 run the launcher with: --second-d8=clang_x86/d8 in an x64 build. Configuring the executable's architecture is now simplified and inferred from the gn build configuration. Building for clusterfuzz has now a new canonical target that can be used by the infrastructure (defaults to d8). The clusterfuzz release builder is now defined to compile multi-arch builds, which will have an effect as soon as the infrastructure refers to the new clusterfuzz target. BUG=chromium:673246 NOTRY=true TBR=mstarzinger,jarin Review-Url: https://codereview.chromium.org/2649133010 Cr-Commit-Position: refs/heads/master@{#42884} Committed: https://chromium.googlesource.com/v8/v8/+/13de00c0be07c772245361e62023792f5a8ec715

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -19 lines) Patch
M BUILD.gn View 1 3 chunks +15 lines, -0 lines 0 comments Download
M gni/v8.gni View 1 1 chunk +3 lines, -0 lines 0 comments Download
M infra/mb/mb_config.pyl View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/foozzie/v8_foozzie.py View 1 2 3 chunks +22 lines, -18 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Michael Achenbach
PTAL
3 years, 10 months ago (2017-02-02 09:33:18 UTC) #4
tandrii(chromium)
lgtm
3 years, 10 months ago (2017-02-02 11:29:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649133010/40001
3 years, 10 months ago (2017-02-02 11:29:50 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-02 11:29:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649133010/40001
3 years, 10 months ago (2017-02-02 11:31:12 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/v8/v8/+/13de00c0be07c772245361e62023792f5a8ec715
3 years, 10 months ago (2017-02-02 11:33:01 UTC) #15
Michael Starzinger
3 years, 10 months ago (2017-02-02 11:37:07 UTC) #16
Message was sent while issue was closed.
LGTM (owner-stamp, I am not familiar enough with the build system to do a proper
review).

Powered by Google App Engine
This is Rietveld 408576698