Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 2649133003: Remove PrioritizeArcInstance() from SessionManagerClient (Closed)

Created:
3 years, 11 months ago by Yusuke Sato
Modified:
3 years, 11 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, hashimoto+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove PrioritizeArcInstance() from SessionManagerClient The interface is deprecated and is no longer used. BUG=684147 TEST=try, git grep PrioritizeArcInstance Review-Url: https://codereview.chromium.org/2649133003 Cr-Commit-Position: refs/heads/master@{#445648} Committed: https://chromium.googlesource.com/chromium/src/+/e749d0e517205a0eb610c6f7667c40a123c19144

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -36 lines) Patch
M chrome/browser/chromeos/settings/device_settings_test_helper.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/settings/device_settings_test_helper.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chromeos/dbus/fake_session_manager_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/fake_session_manager_client.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chromeos/dbus/mock_session_manager_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/session_manager_client.h View 1 chunk +0 lines, -8 lines 0 comments Download
M chromeos/dbus/session_manager_client.cc View 2 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Yusuke Sato
Please take a look.
3 years, 11 months ago (2017-01-24 00:28:53 UTC) #4
Daniel Erat
lgtm
3 years, 11 months ago (2017-01-24 04:39:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649133003/1
3 years, 11 months ago (2017-01-24 04:46:51 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 04:51:57 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e749d0e517205a0eb610c6f7667c...

Powered by Google App Engine
This is Rietveld 408576698