Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 2649103009: chromeos: wires transients using the WindowTreeHost window (Closed)

Created:
3 years, 11 months ago by sky
Modified:
3 years, 11 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: wires transients using the WindowTreeHost window The expectation is transients are honored at the widget level, which corresponds to wiring using the window created by the WindowTreeHost. BUG=685226 TEST=covered by test. R=erg@chromium.org Review-Url: https://codereview.chromium.org/2649103009 Cr-Commit-Position: refs/heads/master@{#446151} Committed: https://chromium.googlesource.com/chromium/src/+/55cd9ef40d390ea5a39089d4b18ea8fe78de5eb8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -12 lines) Patch
M ui/views/mus/desktop_window_tree_host_mus.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M ui/views/mus/desktop_window_tree_host_mus_unittest.cc View 8 chunks +29 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
sky
3 years, 11 months ago (2017-01-25 21:34:34 UTC) #1
Elliot Glaysher
lgtm (i should have asked for a test on that last patch, shouldn't've i?)
3 years, 11 months ago (2017-01-25 21:51:10 UTC) #4
sky
On 2017/01/25 21:51:10, Elliot Glaysher wrote: > lgtm > > (i should have asked for ...
3 years, 11 months ago (2017-01-25 22:17:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649103009/1
3 years, 11 months ago (2017-01-25 22:17:46 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 22:59:55 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/55cd9ef40d390ea5a39089d4b18e...

Powered by Google App Engine
This is Rietveld 408576698