third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.h - Issue 2649103007: Make PropertyHandle instances const references where possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.h

Issue 2649103007: Make PropertyHandle instances const references where possible (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/StringKeyframe.cpp ('k') | third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.h

diff --git a/third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.h b/third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.h

index c5b67aae00d939a82d8b595a079c760e489006a5..14aa1702239c9285501a7a741424ad0cb96cbff7 100644

--- a/third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.h

+++ b/third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.h

@@ -51,7 +51,7 @@ class CORE_EXPORT AnimatableValueKeyframe : public Keyframe {

double offset,

PassRefPtr<TimingFunction> easing) const final;

PassRefPtr<Interpolation> createInterpolation(

- PropertyHandle,

+ const PropertyHandle&,

const Keyframe::PropertySpecificKeyframe& end) const final;

private:

@@ -80,7 +80,7 @@ class CORE_EXPORT AnimatableValueKeyframe : public Keyframe {

PassRefPtr<Keyframe> clone() const override;

PassRefPtr<Keyframe::PropertySpecificKeyframe> createPropertySpecificKeyframe(

- PropertyHandle) const override;

+ const PropertyHandle&) const override;

bool isAnimatableValueKeyframe() const override { return true; }