third_party/WebKit/Source/core/animation/StringKeyframe.cpp - Issue 2649103007: Make PropertyHandle instances const references where possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/StringKeyframe.cpp

Issue 2649103007: Make PropertyHandle instances const references where possible (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/animation/StringKeyframe.cpp

diff --git a/third_party/WebKit/Source/core/animation/StringKeyframe.cpp b/third_party/WebKit/Source/core/animation/StringKeyframe.cpp

index 420eafc6c8c31204ab99caa264cff832fad6bdf0..7f6bb9ff9a12d9a22745bbcbd3278c741543413d 100644

--- a/third_party/WebKit/Source/core/animation/StringKeyframe.cpp

+++ b/third_party/WebKit/Source/core/animation/StringKeyframe.cpp

@@ -100,7 +100,8 @@ PassRefPtr<Keyframe> StringKeyframe::clone() const {

}

PassRefPtr<Keyframe::PropertySpecificKeyframe>

-StringKeyframe::createPropertySpecificKeyframe(PropertyHandle property) const {

+StringKeyframe::createPropertySpecificKeyframe(

+ const PropertyHandle& property) const {

if (property.isCSSProperty())

return CSSPropertySpecificKeyframe::create(

offset(), &easing(), &cssPropertyValue(property), composite());