third_party/WebKit/Source/core/animation/EffectModel.h - Issue 2649103007: Make PropertyHandle instances const references where possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/EffectModel.h

Issue 2649103007: Make PropertyHandle instances const references where possible (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/animation/EffectModel.h

diff --git a/third_party/WebKit/Source/core/animation/EffectModel.h b/third_party/WebKit/Source/core/animation/EffectModel.h

index 58b722f667502edd880601863d6632942e51ea9a..0966cccbfd5774f62be8e63b7bbf073c8e5e2697 100644

--- a/third_party/WebKit/Source/core/animation/EffectModel.h

+++ b/third_party/WebKit/Source/core/animation/EffectModel.h

@@ -58,7 +58,7 @@ class CORE_EXPORT EffectModel : public GarbageCollectedFinalized<EffectModel> {

double iterationDuration,

Vector<RefPtr<Interpolation>>&) const = 0;

- virtual bool affects(PropertyHandle) const { return false; }

+ virtual bool affects(const PropertyHandle&) const { return false; }

virtual bool isTransformRelatedEffect() const { return false; }

virtual bool isKeyframeEffectModel() const { return false; }

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/animation/Interpolation.h » ('j') | no next file with comments »