Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Side by Side Diff: third_party/WebKit/Source/core/animation/EffectModel.h

Issue 2649103007: Make PropertyHandle instances const references where possible (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/animation/Interpolation.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 CompositeAdd, 51 CompositeAdd,
52 }; 52 };
53 53
54 EffectModel() {} 54 EffectModel() {}
55 virtual ~EffectModel() {} 55 virtual ~EffectModel() {}
56 virtual bool sample(int iteration, 56 virtual bool sample(int iteration,
57 double fraction, 57 double fraction,
58 double iterationDuration, 58 double iterationDuration,
59 Vector<RefPtr<Interpolation>>&) const = 0; 59 Vector<RefPtr<Interpolation>>&) const = 0;
60 60
61 virtual bool affects(PropertyHandle) const { return false; } 61 virtual bool affects(const PropertyHandle&) const { return false; }
62 virtual bool isTransformRelatedEffect() const { return false; } 62 virtual bool isTransformRelatedEffect() const { return false; }
63 virtual bool isKeyframeEffectModel() const { return false; } 63 virtual bool isKeyframeEffectModel() const { return false; }
64 64
65 DEFINE_INLINE_VIRTUAL_TRACE() {} 65 DEFINE_INLINE_VIRTUAL_TRACE() {}
66 }; 66 };
67 67
68 } // namespace blink 68 } // namespace blink
69 69
70 #endif // EffectModel_h 70 #endif // EffectModel_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/animation/Interpolation.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698