Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 26491010: [Android] Don't hide text handles if they are being dragged (Closed)

Created:
7 years, 2 months ago by cjhopman
Modified:
7 years, 2 months ago
Reviewers:
joth
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

[Android] Don't hide text handles if they are being dragged In webview, hiding of text handles can be triggered by many events (containing view being scrolled, capturePicture call, etc.). If the user is dragging a handle, we don't actually want to hide it. Instead, explicitly suppress hiding of text handles while they are being dragged. BUG=b/10723151 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228728

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/InsertionHandleController.java View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
cjhopman
joth: *
7 years, 2 months ago (2013-10-15 01:17:41 UTC) #1
joth
lgtm
7 years, 2 months ago (2013-10-15 04:38:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/26491010/6001
7 years, 2 months ago (2013-10-15 04:39:01 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-15 05:06:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/26491010/31001
7 years, 2 months ago (2013-10-15 15:48:17 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-15 18:24:51 UTC) #6
Message was sent while issue was closed.
Change committed as 228728

Powered by Google App Engine
This is Rietveld 408576698