Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2649093002: [builtins] Pass NotNullOrUndefined to ToPrimitive calls. (Closed)

Created:
3 years, 11 months ago by Benedikt Meurer
Modified:
3 years, 11 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Pass NotNullOrUndefined to ToPrimitive calls. For calls from ToPrimitive we already now that the receiver cannot be null or undefined, since a property lookup succeeded before the call, which would have thrown an exception in case of null or undefined. R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2649093002 Cr-Commit-Position: refs/heads/master@{#42589} Committed: https://chromium.googlesource.com/v8/v8/+/7b6ac70a4a07e7da74046ba2057488c8775c8931

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M src/builtins/builtins-conversion.cc View 6 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Benedikt Meurer
3 years, 11 months ago (2017-01-23 08:31:38 UTC) #1
Yang
On 2017/01/23 08:31:38, Benedikt Meurer wrote: lgtm.
3 years, 11 months ago (2017-01-23 08:32:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649093002/1
3 years, 11 months ago (2017-01-23 08:33:27 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 09:01:05 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/7b6ac70a4a07e7da74046ba2057488c8775...

Powered by Google App Engine
This is Rietveld 408576698