Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 2649063003: Revert of Query NaCl processes' GDB debug port on the correct thread. (Closed)

Created:
3 years, 11 months ago by Wez
Modified:
3 years, 11 months ago
Reviewers:
afakhry, bradnelson
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Query NaCl processes' GDB debug port on the correct thread. (patchset #1 id:1 of https://codereview.chromium.org/2634573003/ ) Reason for revert: This fix introduced a typo in the background refresh flags mask, breaking it. Original issue's description: > Query NaCl processes' GDB debug port on the correct thread. > > TaskGroup previously called NaClBrowser on the UI thread, to refresh the > GDB debug port information for NaCl processes. NaClBrowser is designed > to be accessed only from the Browser's IO thread; this patch fixes that. > > BUG=630861 > > Review-Url: https://codereview.chromium.org/2634573003 > Cr-Commit-Position: refs/heads/master@{#444849} > Committed: https://chromium.googlesource.com/chromium/src/+/f0bd838cce8870a95aec33be0b58151bd80f96aa TBR=afakhry@chromium.org,bradnelson@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=630861, 684042 Review-Url: https://codereview.chromium.org/2649063003 Cr-Commit-Position: refs/heads/master@{#445485} Committed: https://chromium.googlesource.com/chromium/src/+/01f28a09b779a3081b4c485dae8e25e7fe8eba40

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -23 lines) Patch
M chrome/browser/task_manager/sampling/task_group.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/task_manager/sampling/task_group.cc View 3 chunks +7 lines, -20 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
Wez
Created Revert of Query NaCl processes' GDB debug port on the correct thread.
3 years, 11 months ago (2017-01-23 19:58:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649063003/1
3 years, 11 months ago (2017-01-23 19:58:52 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/218103)
3 years, 11 months ago (2017-01-23 20:10:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649063003/1
3 years, 11 months ago (2017-01-23 20:22:51 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 21:13:11 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/01f28a09b779a3081b4c485dae8e...

Powered by Google App Engine
This is Rietveld 408576698