Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2649053002: X87: [builtins] Don't put doubles on the stack in ConstructWithSpread. (Closed)

Created:
3 years, 11 months ago by zhengxing.li
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [builtins] Don't put doubles on the stack in ConstructWithSpread. port ee9c709190b1a5a8c32fbcffb33f8ebe5cb20673 (r42561) original commit message: FAST_DOUBLE_ELEMENTS and FAST_HOLEY_DOUBLE_ELEMENTS kinds should both be handled by the runtime. BUG= Review-Url: https://codereview.chromium.org/2649053002 Cr-Commit-Position: refs/heads/master@{#42592} Committed: https://chromium.googlesource.com/v8/v8/+/68289fd9f501d5ab3c0815e6ca80f8497f740708

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M src/builtins/x87/builtins-x87.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
zhengxing.li
PTAL, thanks!
3 years, 11 months ago (2017-01-23 07:15:42 UTC) #2
petermarshall
lgtm
3 years, 11 months ago (2017-01-23 08:21:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649053002/1
3 years, 11 months ago (2017-01-23 08:21:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649053002/1
3 years, 11 months ago (2017-01-23 09:12:06 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 09:14:07 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/68289fd9f501d5ab3c0815e6ca80f8497f7...

Powered by Google App Engine
This is Rietveld 408576698