Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2649043011: Media Remoting: Exit remoting only if playback is continuously delayed. (Closed)

Created:
3 years, 11 months ago by xjz
Modified:
3 years, 11 months ago
Reviewers:
miu
CC:
chromium-reviews, chromoting-reviews_chromium.org, feature-media-reviews_chromium.org, apacible+watch_chromium.org, xjz+watch_chromium.org, erickung+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Media Remoting: Exit remoting only if playback is continuously delayed. The local time to process the TimeUpdate RPC message is used to detect whether playback is delayed. Since the RPC message might not be processed in time, only exits remoting if playback is continously delayed. BUG=684749 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2638393005 Cr-Original-Commit-Position: refs/heads/master@{#445136} Review-Url: https://codereview.chromium.org/2649043011 Cr-Commit-Position: refs/branch-heads/2987@{#97} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/caa1af7df4e21b4157fec59bc994ded8095b90b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M media/remoting/remote_renderer_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M media/remoting/remote_renderer_impl.cc View 2 chunks +12 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649043011/1
3 years, 11 months ago (2017-01-25 23:42:50 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 11 months ago (2017-01-25 23:42:51 UTC) #4
miu
lgtm
3 years, 11 months ago (2017-01-25 23:44:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649043011/1
3 years, 11 months ago (2017-01-25 23:44:48 UTC) #7
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 11 months ago (2017-01-25 23:44:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649043011/1
3 years, 11 months ago (2017-01-25 23:47:12 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 23:48:47 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/caa1af7df4e21b4157fec59bc994...

Powered by Google App Engine
This is Rietveld 408576698