Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2649043010: Remove flakiness from one copy partial raster tests (Closed)

Created:
3 years, 11 months ago by ericrk
Modified:
3 years, 11 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove flakiness from one copy partial raster tests The one copy path relied on GL command buffer progress in order for staging resources to become available for partial raster. This wasn't guaranteed. This change adds a flush before we attempt to partial raster, ensuring that the staging resources are available. R=danakj@chromium.org BUG=676852 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2649043010 Cr-Commit-Position: refs/heads/master@{#446205} Committed: https://chromium.googlesource.com/chromium/src/+/afec1af82eb9103f39034c0909e32e9c0341f9aa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M cc/trees/layer_tree_host_pixeltest_tiles.cc View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
ericrk
Another general fix factored out of the on-hold ForceReclaimResources patch.
3 years, 11 months ago (2017-01-25 22:15:06 UTC) #2
danakj
LGTM
3 years, 11 months ago (2017-01-25 22:15:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649043010/1
3 years, 11 months ago (2017-01-26 01:58:16 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 02:06:41 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/afec1af82eb9103f39034c0909e3...

Powered by Google App Engine
This is Rietveld 408576698