Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2649043005: Make DiskCacheBasedQuicServerInfo release buffers when no longer needed (Closed)

Created:
3 years, 11 months ago by xunjieli
Modified:
3 years, 11 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make DiskCacheBasedQuicServerInfo release buffers when no longer needed When read/write is completed in DiskCacheBasedQuicServerInfo, release read/write IOBuffer. BUG=684732 Review-Url: https://codereview.chromium.org/2649043005 Cr-Commit-Position: refs/heads/master@{#445873} Committed: https://chromium.googlesource.com/chromium/src/+/e60eae52ad27b1d5814eeecf6575916be0e5b14c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M net/http/disk_cache_based_quic_server_info.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
xunjieli
Ryan, PTAL. Thanks
3 years, 11 months ago (2017-01-24 21:01:41 UTC) #2
Ryan Hamilton
lgtm
3 years, 11 months ago (2017-01-24 23:14:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649043005/1
3 years, 11 months ago (2017-01-24 23:15:57 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 00:24:39 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e60eae52ad27b1d5814eeecf6575...

Powered by Google App Engine
This is Rietveld 408576698