Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2648943002: WebAPK: Save TabState for WebappManagedActivities and WebApkManagedActivities in different director… (Closed)

Created:
3 years, 11 months ago by pkotwicz
Modified:
3 years, 11 months ago
Reviewers:
gone
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebAPK: Save TabState for WebappManagedActivities and WebApkManagedActivities in different directories Previously, it was possible for a WebappManagedActivity to clobber a WebApkManagedActivity's state and vice versa BUG=683627 Review-Url: https://codereview.chromium.org/2648943002 Cr-Commit-Position: refs/heads/master@{#445504} Committed: https://chromium.googlesource.com/chromium/src/+/a88e6cab0f9736a8eef7fe09dfc9e3d8fdbf90f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkManagedActivity.java View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
pkotwicz
Dan, can you please take a look? I am thinking of merging this CL back ...
3 years, 11 months ago (2017-01-22 02:27:37 UTC) #3
gone
lgtm
3 years, 11 months ago (2017-01-23 19:11:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2648943002/1
3 years, 11 months ago (2017-01-23 21:17:56 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 22:06:06 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a88e6cab0f9736a8eef7fe09dfc9...

Powered by Google App Engine
This is Rietveld 408576698