Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(953)

Issue 26489003: Insert swapbuffers into GPU benchmarks. (Closed)

Created:
7 years, 2 months ago by djsollen
Modified:
7 years, 2 months ago
Reviewers:
bsalomon, mtklein
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Insert swapbuffers into GPU benchmarks. R=mtklein@google.com Committed: https://code.google.com/p/skia/source/detail?r=11704

Patch Set 1 #

Patch Set 2 : getting close #

Patch Set 3 : rebase #

Patch Set 4 : stats #

Total comments: 1

Patch Set 5 : resetGpuContext #

Patch Set 6 : resetGpuContext #

Patch Set 7 : remote resetGpuContext #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -18 lines) Patch
M bench/benchmain.cpp View 1 2 3 5 6 4 chunks +66 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
djsollen
7 years, 2 months ago (2013-10-10 14:49:04 UTC) #1
djsollen
The nexus 4 almost makes a complete run before dying, but I'll have to see ...
7 years, 2 months ago (2013-10-10 14:50:07 UTC) #2
mtklein
lgtm https://codereview.chromium.org/26489003/diff/6001/bench/benchmain.cpp File bench/benchmain.cpp (right): https://codereview.chromium.org/26489003/diff/6001/bench/benchmain.cpp#newcode650 bench/benchmain.cpp:650: // currently we only setup the frame interval ...
7 years, 2 months ago (2013-10-10 15:01:05 UTC) #3
djsollen
the bitmap_8888_update* benches can be run upwards of 524,288 times and still not converge. This ...
7 years, 2 months ago (2013-10-10 17:00:09 UTC) #4
djsollen
7 years, 2 months ago (2013-10-10 17:33:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #7 manually as r11704 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698