Add a histogram for a number of HTTP passwords migrated to HTTPS.

Add a histogram for a number of HTTP passwords migrated to HTTPS.

BUG=571580
Review-Url: https://codereview.chromium.org/2648783002
Cr-Commit-Position: refs/heads/master@{#445360}
Committed: https://chromium.googlesource.com/chromium/src/+/dbd454bb75c5dbd8e74e8d967299b4cd7852dec8

[vasilii, 2017-01-20 16:58:11]

The CQ bit was checked by vasilii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 16:58:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vasilii, 2017-01-20 16:58:39]

vasilii@chromium.org changed reviewers:
+ isherman@chromium.org

[vasilii, 2017-01-20 16:58:40]

Hi Ilya,

please review.

[commit-bot: I haz the power, 2017-01-20 18:07:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 18:07:42]

Dry run: This issue passed the CQ dry run.

[Ilya Sherman, 2017-01-21 00:23:17]

Metrics LGTM % comments:

https://codereview.chromium.org/2648783002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2648783002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:44813: +<histogram
name="PasswordManager.HttpMigrationCount">
Please specify the units.

https://codereview.chromium.org/2648783002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:44815: +  <summary>Number of HTTP saved
passwords that were migrated to HTTPS.</summary>
Please document when this is recorded.

[vasilii, 2017-01-23 10:55:46]

https://codereview.chromium.org/2648783002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2648783002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:44813: +<histogram
name="PasswordManager.HttpMigrationCount">
On 2017/01/21 00:23:16, Ilya Sherman wrote:
> Please specify the units.

Done.

https://codereview.chromium.org/2648783002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:44815: +  <summary>Number of HTTP saved
passwords that were migrated to HTTPS.</summary>
On 2017/01/21 00:23:16, Ilya Sherman wrote:
> Please document when this is recorded.

Done.

[vasilii, 2017-01-23 10:55:49]

The CQ bit was checked by vasilii@chromium.org

[vasilii, 2017-01-23 10:55:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2648783002/#ps20001
(title: "comments")

[commit-bot: I haz the power, 2017-01-23 10:56:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 12:00:12]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485168949194600,
"parent_rev": "624f5ca32fa119fa193ef10cb89016d485589fe3", "commit_rev":
"dbd454bb75c5dbd8e74e8d967299b4cd7852dec8"}

[commit-bot: I haz the power, 2017-01-23 12:00:45]

Description was changed from

==========
Add a histogram for a number of HTTP passwords migrated to HTTPS.

BUG=571580
==========

to

==========
Add a histogram for a number of HTTP passwords migrated to HTTPS.

BUG=571580

Review-Url: https://codereview.chromium.org/2648783002
Cr-Commit-Position: refs/heads/master@{#445360}
Committed:
https://chromium.googlesource.com/chromium/src/+/dbd454bb75c5dbd8e74e8d967299...
==========

[commit-bot: I haz the power, 2017-01-23 12:00:46]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dbd454bb75c5dbd8e74e8d967299...

[Ilya Sherman, 2017-01-23 20:22:59]

https://codereview.chromium.org/2648783002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2648783002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:44944: +<histogram
name="PasswordManager.HttpPasswordMigrationCount">
Sorry for not being clear enough previously.  I meant: Please add an attribute
like units="saved credential entries".

https://codereview.chromium.org/2648783002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:44948: +    password form load.
Hmm, is this recorded on *every* password form load?  That would suggest this
histogram would have mostly zeroes, which I'm assuming isn't the case.  Could
you please provide some more detail to clarify when this is recorded?