Replace CXFA_StrokeArray and CXFA_WidgetArray with std::vector

Replace CXFA_StrokeArray and CXFA_WidgetArray with std::vector

Review-Url: https://codereview.chromium.org/2648773003
Committed: https://pdfium.googlesource.com/pdfium/+/a0b2d23d1121202d3821291483943a47a3c9e32e

[Tom Sepez, 2017-01-20 21:36:50]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 21:36:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2017-01-20 21:38:14]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org, npm@chromium.org

[Tom Sepez, 2017-01-20 21:38:15]

npm, Dan, for review.  This was a little trickier owing to the signed indexing
and the co-incidence that (notfound) + 1 == 0 when -1 is the notfound sentinel.

[commit-bot: I haz the power, 2017-01-20 21:55:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 21:55:04]

Dry run: This issue passed the CQ dry run.

[npm, 2017-01-23 14:49:51]

lgtm

https://codereview.chromium.org/2648773003/diff/60001/xfa/fxfa/app/xfa_ffpage...
File xfa/fxfa/app/xfa_ffpageview.cpp (right):

https://codereview.chromium.org/2648773003/diff/60001/xfa/fxfa/app/xfa_ffpage...
xfa/fxfa/app/xfa_ffpageview.cpp:250: if (!m_TabOrderWidgetArray.empty()) {
Do you need this if, or can it also be deleted?

https://codereview.chromium.org/2648773003/diff/60001/xfa/fxfa/app/xfa_ffwidg...
File xfa/fxfa/app/xfa_ffwidget.cpp (right):

https://codereview.chromium.org/2648773003/diff/60001/xfa/fxfa/app/xfa_ffwidg...
xfa/fxfa/app/xfa_ffwidget.cpp:2042: if (!(dwFlags & XFA_DRAWBOX_ForceRound) &&
eType != XFA_Element::Arc) {
Nit: no {}

https://codereview.chromium.org/2648773003/diff/60001/xfa/fxfa/parser/cxfa_bo...
File xfa/fxfa/parser/cxfa_box.cpp (right):

https://codereview.chromium.org/2648773003/diff/60001/xfa/fxfa/parser/cxfa_bo...
xfa/fxfa/parser/cxfa_box.cpp:30: (*strokes)[j] = CXFA_Stroke(nullptr);
Now this can be CXFA_Stroke(), right?

https://codereview.chromium.org/2648773003/diff/60001/xfa/fxfa/parser/cxfa_bo...
xfa/fxfa/parser/cxfa_box.cpp:42: (*strokes)[j] = CXFA_Stroke(nullptr);
ditto

[Tom Sepez, 2017-01-23 18:36:51]

Please double-check the logic change in cxfa_box.cpp.

https://codereview.chromium.org/2648773003/diff/60001/xfa/fxfa/app/xfa_ffpage...
File xfa/fxfa/app/xfa_ffpageview.cpp (right):

https://codereview.chromium.org/2648773003/diff/60001/xfa/fxfa/app/xfa_ffpage...
xfa/fxfa/app/xfa_ffpageview.cpp:250: if (!m_TabOrderWidgetArray.empty()) {
On 2017/01/23 14:49:50, npm wrote:
> Do you need this if, or can it also be deleted?

I kept it so that if we decide to go to signed indexing, we don't compute  0 - 1
= big on line 251.

https://codereview.chromium.org/2648773003/diff/60001/xfa/fxfa/app/xfa_ffwidg...
File xfa/fxfa/app/xfa_ffwidget.cpp (right):

https://codereview.chromium.org/2648773003/diff/60001/xfa/fxfa/app/xfa_ffwidg...
xfa/fxfa/app/xfa_ffwidget.cpp:2042: if (!(dwFlags & XFA_DRAWBOX_ForceRound) &&
eType != XFA_Element::Arc) {
On 2017/01/23 14:49:50, npm wrote:
> Nit: no {}

Done.

https://codereview.chromium.org/2648773003/diff/60001/xfa/fxfa/parser/cxfa_bo...
File xfa/fxfa/parser/cxfa_box.cpp (right):

https://codereview.chromium.org/2648773003/diff/60001/xfa/fxfa/parser/cxfa_bo...
xfa/fxfa/parser/cxfa_box.cpp:30: (*strokes)[j] = CXFA_Stroke(nullptr);
On 2017/01/23 14:49:50, npm wrote:
> Now this can be CXFA_Stroke(), right?

Actually, now that I added the default ctor, the resize above takes care of this
for us and we're storing a null stroke on top of a null stroke.
Fixed logic.

https://codereview.chromium.org/2648773003/diff/60001/xfa/fxfa/parser/cxfa_bo...
xfa/fxfa/parser/cxfa_box.cpp:42: (*strokes)[j] = CXFA_Stroke(nullptr);
On 2017/01/23 14:49:50, npm wrote:
> ditto

ditto

[npm, 2017-01-23 18:51:51]

https://codereview.chromium.org/2648773003/diff/60001/xfa/fxfa/app/xfa_ffpage...
File xfa/fxfa/app/xfa_ffpageview.cpp (right):

https://codereview.chromium.org/2648773003/diff/60001/xfa/fxfa/app/xfa_ffpage...
xfa/fxfa/app/xfa_ffpageview.cpp:250: if (!m_TabOrderWidgetArray.empty()) {
On 2017/01/23 18:36:51, Tom Sepez wrote:
> On 2017/01/23 14:49:50, npm wrote:
> > Do you need this if, or can it also be deleted?
> 
> I kept it so that if we decide to go to signed indexing, we don't compute  0 -
1
> = big on line 251.

Won't it be -1, since you are using int? Also, why keep here and remove from the
above method?

https://codereview.chromium.org/2648773003/diff/60001/xfa/fxfa/parser/cxfa_bo...
File xfa/fxfa/parser/cxfa_box.cpp (right):

https://codereview.chromium.org/2648773003/diff/60001/xfa/fxfa/parser/cxfa_bo...
xfa/fxfa/parser/cxfa_box.cpp:30: (*strokes)[j] = CXFA_Stroke(nullptr);
On 2017/01/23 18:36:51, Tom Sepez wrote:
> On 2017/01/23 14:49:50, npm wrote:
> > Now this can be CXFA_Stroke(), right?
> 
> Actually, now that I added the default ctor, the resize above takes care of
this
> for us and we're storing a null stroke on top of a null stroke.
> Fixed logic.

Acknowledged.

https://codereview.chromium.org/2648773003/diff/60001/xfa/fxfa/parser/cxfa_bo...
xfa/fxfa/parser/cxfa_box.cpp:42: (*strokes)[j] = CXFA_Stroke(nullptr);
On 2017/01/23 18:36:51, Tom Sepez wrote:
> On 2017/01/23 14:49:50, npm wrote:
> > ditto
> 
> ditto

Acknowledged.

[Tom Sepez, 2017-01-23 18:59:45]

https://codereview.chromium.org/2648773003/diff/60001/xfa/fxfa/app/xfa_ffpage...
File xfa/fxfa/app/xfa_ffpageview.cpp (right):

https://codereview.chromium.org/2648773003/diff/60001/xfa/fxfa/app/xfa_ffpage...
xfa/fxfa/app/xfa_ffpageview.cpp:250: if (!m_TabOrderWidgetArray.empty()) {
On 2017/01/23 18:51:51, npm wrote:
> On 2017/01/23 18:36:51, Tom Sepez wrote:
> > On 2017/01/23 14:49:50, npm wrote:
> > > Do you need this if, or can it also be deleted?
> > 
> > I kept it so that if we decide to go to signed indexing, we don't compute  0
-
> 1
> > = big on line 251.
> 
> Won't it be -1, since you are using int? Also, why keep here and remove from
the
> above method?
Fixed.

[Tom Sepez, 2017-01-23 18:59:49]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2017-01-23 18:59:50]

The patchset sent to the CQ was uploaded after l-g-t-m from npm@chromium.org
Link to the patchset: https://codereview.chromium.org/2648773003/#ps100001
(title: "remove if")

[commit-bot: I haz the power, 2017-01-23 18:59:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 19:32:37]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1485197989589840,
"parent_rev": "c757d9a6f90bb879ce2cdd4a756b7b0e1885eb25", "commit_rev":
"a0b2d23d1121202d3821291483943a47a3c9e32e"}

[commit-bot: I haz the power, 2017-01-23 19:32:40]

Description was changed from

==========
Replace CXFA_StrokeArray and CXFA_WidgetArray with std::vector
==========

to

==========
Replace CXFA_StrokeArray and CXFA_WidgetArray with std::vector

Review-Url: https://codereview.chromium.org/2648773003
Committed:
https://pdfium.googlesource.com/pdfium/+/a0b2d23d1121202d3821291483943a47a3c9...
==========

[commit-bot: I haz the power, 2017-01-23 19:32:41]

Committed patchset #6 (id:100001) as
https://pdfium.googlesource.com/pdfium/+/a0b2d23d1121202d3821291483943a47a3c9...