Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 2648753002: Revert of Inline Document::allowExecutingScripts logic (Closed)

Created:
3 years, 11 months ago by haraken
Modified:
3 years, 11 months ago
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Inline Document::allowExecutingScripts logic (patchset #3 id:40001 of https://codereview.chromium.org/2640983005/ ) Reason for revert: This caused memory leaks in Linux Leak Detector: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/1655 Original issue's description: > Inline Document::allowExecutingScripts logic > > This CL removes and inlines Document::allowExecutingScripts predicate > to ScriptLoader::prepareScript, where it was only called. > > BUG=None > > Review-Url: https://codereview.chromium.org/2640983005 > Cr-Commit-Position: refs/heads/master@{#445023} > Committed: https://chromium.googlesource.com/chromium/src/+/6432181413b6162f3e78704987fe0f7c61e7c185 TBR=yukishiino@chromium.org,hiroshige@chromium.org,kouhei@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review-Url: https://codereview.chromium.org/2648753002 Cr-Commit-Position: refs/heads/master@{#445039} Committed: https://chromium.googlesource.com/chromium/src/+/f116503fb64582fe3c85a1589a1898570976d3cb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -26 lines) Patch
M third_party/WebKit/Source/core/dom/Document.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptLoader.cpp View 2 chunks +9 lines, -26 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
haraken
Created Revert of Inline Document::allowExecutingScripts logic
3 years, 11 months ago (2017-01-20 11:19:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2648753002/1
3 years, 11 months ago (2017-01-20 11:19:44 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 11:20:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f116503fb64582fe3c85a1589a18...

Powered by Google App Engine
This is Rietveld 408576698