Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3636)

Unified Diff: chrome/browser/safe_browsing/certificate_reporting_service.h

Issue 2648713002: Add response code to the success callback of ReportSender (Closed)
Patch Set: eroman and estark comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/certificate_reporting_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/certificate_reporting_service.h
diff --git a/chrome/browser/safe_browsing/certificate_reporting_service.h b/chrome/browser/safe_browsing/certificate_reporting_service.h
index 5d02a23218fafbce8bf5e35cdde78208d5de9720..639b27e34a9372cde43e7d421b50b78601425bae 100644
--- a/chrome/browser/safe_browsing/certificate_reporting_service.h
+++ b/chrome/browser/safe_browsing/certificate_reporting_service.h
@@ -126,7 +126,14 @@ class CertificateReportingService : public KeyedService {
private:
void SendInternal(const Report& report);
- void ErrorCallback(int report_id, const GURL& url, int error);
+ // Called when a report upload fails either because of a net error or a
+ // non-HTTP 200 response code. See
+ // TransportSecurityState::ReportSenderInterface for parameters.
+ void ErrorCallback(int report_id,
+ const GURL& url,
+ int net_error,
+ int http_response_code);
+ // Called when a report upload is successful.
void SuccessCallback(int report_id);
std::unique_ptr<certificate_reporting::ErrorReporter> error_reporter_;
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/certificate_reporting_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698