Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5762)

Unified Diff: chrome/browser/safe_browsing/certificate_reporting_service.cc

Issue 2648713002: Add response code to the success callback of ReportSender (Closed)
Patch Set: eroman and estark comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/certificate_reporting_service.cc
diff --git a/chrome/browser/safe_browsing/certificate_reporting_service.cc b/chrome/browser/safe_browsing/certificate_reporting_service.cc
index f95c37243c743dbdfe531377295702215bad64b0..e99cd08be5b9f0e94c55d579504c061177760c24 100644
--- a/chrome/browser/safe_browsing/certificate_reporting_service.cc
+++ b/chrome/browser/safe_browsing/certificate_reporting_service.cc
@@ -152,11 +152,13 @@ void CertificateReportingService::Reporter::SendInternal(
weak_factory_.GetWeakPtr(), report.report_id));
}
-void CertificateReportingService::Reporter::ErrorCallback(int report_id,
- const GURL& url,
- int error) {
+void CertificateReportingService::Reporter::ErrorCallback(
+ int report_id,
+ const GURL& url,
+ int net_error,
+ int http_response_code) {
DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
- RecordUMAOnFailure(error);
+ RecordUMAOnFailure(net_error);
if (retries_enabled_) {
auto it = inflight_reports_.find(report_id);
DCHECK(it != inflight_reports_.end());

Powered by Google App Engine
This is Rietveld 408576698