Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Unified Diff: net/url_request/report_sender.cc

Issue 2648713002: Add response code to the success callback of ReportSender (Closed)
Patch Set: Move http_response_code to error callback Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/report_sender.cc
diff --git a/net/url_request/report_sender.cc b/net/url_request/report_sender.cc
index 96263d7f2b4ea4b1f87e98508e4723613cd3b0dc..070e77e5eecebe45e9068f554d0dd452849b6037 100644
--- a/net/url_request/report_sender.cc
+++ b/net/url_request/report_sender.cc
@@ -10,6 +10,7 @@
#include "net/base/load_flags.h"
#include "net/base/request_priority.h"
#include "net/base/upload_bytes_element_reader.h"
+#include "net/http/http_status_code.h"
#include "net/url_request/url_request_context.h"
#include "net/url_request/url_request_status.h"
@@ -91,11 +92,15 @@ void ReportSender::OnResponseStarted(URLRequest* request, int net_error) {
if (net_error != OK) {
DVLOG(1) << "Failed to send report for " << request->url().host();
if (!callback_info->error_callback().is_null())
- callback_info->error_callback().Run(request->url(), net_error);
- } else if (!callback_info->success_callback().is_null()) {
- callback_info->success_callback().Run();
+ callback_info->error_callback().Run(request->url(), net_error, 0);
eroman 2017/04/26 22:52:28 I suggest using -1 instead of 0 (as that is what G
meacer 2017/04/27 00:56:42 Done.
+ } else if (request->GetResponseCode() != net::HTTP_OK) {
+ if (!callback_info->error_callback().is_null())
+ callback_info->error_callback().Run(request->url(), OK,
+ request->GetResponseCode());
+ } else {
+ if (!callback_info->success_callback().is_null())
+ callback_info->success_callback().Run();
}
-
CHECK_GT(inflight_requests_.erase(request), 0u);
}

Powered by Google App Engine
This is Rietveld 408576698