Add response code to the success callback of ReportSender

net/http/transport_security_state.h

Index: net/http/transport_security_state.h
diff --git a/net/http/transport_security_state.h b/net/http/transport_security_state.h
index 5974f27288cb449410d963a159bec6c347f834cd..ced314e7396d0b588412727d5d21eafa27fab150 100644
--- a/net/http/transport_security_state.h
+++ b/net/http/transport_security_state.h
@@ -284,14 +284,19 @@ class NET_EXPORT TransportSecurityState
     // Sends the given serialized |report| to |report_uri| with
     // Content-Type header as specified in
     // |content_type|. |content_type| should be non-empty.
-    // |report_id| could be any non-negative integer. It's passed back to the
-    // error or success callbacks.
-    virtual void Send(
-        const GURL& report_uri,
-        base::StringPiece content_type,
-        base::StringPiece report,
-        const base::Callback<void()>& success_callback,
-        const base::Callback<void(const GURL&, int)>& error_callback) = 0;
+    // |success_callback| is called iff an HTTP 200 response is received.
+    // |error_callback| is called in all other cases. Error callback's
+    // |net_error| can be net::OK if the upload was successful but the server
+    // returned a non-HTTP 200 |http_response_code|. In all other cases,
+    // error callback's |http_response_code| is zero.

[eroman, 2017/04/26 22:52:28]

I suggest making it default to -1 instead (as that is what URLRequest will
return when it doesn't have an HTTP status)

[meacer, 2017/04/27 00:56:42]

Done.

+    virtual void Send(const GURL& report_uri,
+                      base::StringPiece content_type,
+                      base::StringPiece report,
+                      const base::Callback<void()>& success_callback,
+                      const base::Callback<void(const GURL&,
+                                                int /* net_error */,
+                                                int /* http_response_code */)>&
+                          error_callback) = 0;
 
    protected:
     virtual ~ReportSenderInterface() {}