Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 2648683002: Workaround NetworkConnectionManager race condition (Closed)

Created:
3 years, 11 months ago by Pete Williamson
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Workaround NetworkConnectionManager race condition Sometimes when GCM NetworkManager fires, Chromium doesn't yet know that we have a connection, and reports the current connection type as CONNECTION_NONE, even though android reports that we have a connection. If we find a time when NetworkConnectionManager says there is no connection, but android says there is a connection, send a valid connection type down to the request coordinator, so it can start downloading a file. We need to merge this to M56. BUG=680831 Review-Url: https://codereview.chromium.org/2632573002 Cr-Commit-Position: refs/heads/master@{#444121} (cherry picked from commit 87501749a54ab7879f4233e15a4fdb9b0f6adc46) Review-Url: https://codereview.chromium.org/2648683002 . Cr-Commit-Position: refs/branch-heads/2924@{#811} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/28216f1cdf9cce15ba59140c789676ae05f9b353

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java View 2 chunks +37 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Pete Williamson
3 years, 11 months ago (2017-01-20 00:52:24 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
28216f1cdf9cce15ba59140c789676ae05f9b353.

Powered by Google App Engine
This is Rietveld 408576698