Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 2648623003: Revert of Disable OmniboxViewTest.DeleteItem on windows due to continuing flakiness (Closed)

Created:
3 years, 11 months ago by gab
Modified:
3 years, 11 months ago
CC:
chromium-reviews, jdonnelly+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable OmniboxViewTest.DeleteItem on windows due to continuing flakiness (patchset #1 id:1 of https://codereview.chromium.org/2637763004/ ) Reason for revert: Trying to re enable after flake culprit was reverted Original issue's description: > Disable OmniboxViewTest.DeleteItem on windows due to continuing flakiness > > BUG=680698 > TBR=thomasanderson@chromium.org > > Review-Url: https://codereview.chromium.org/2637763004 > Cr-Commit-Position: refs/heads/master@{#443988} > Committed: https://chromium.googlesource.com/chromium/src/+/90fc0c189acd57a5365f07b6613d25b78011cddd TBR=alancutter@chromium.org,thomasanderson@chromium.org,meade@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=680698 Review-Url: https://codereview.chromium.org/2648623003 Cr-Commit-Position: refs/heads/master@{#445011} Committed: https://chromium.googlesource.com/chromium/src/+/6c59727f79b04675fdc9dc663fa36d16b23535b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
gab
Created Revert of Disable OmniboxViewTest.DeleteItem on windows due to continuing flakiness
3 years, 11 months ago (2017-01-20 06:40:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2648623003/1
3 years, 11 months ago (2017-01-20 06:41:03 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 07:51:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6c59727f79b04675fdc9dc663fa3...

Powered by Google App Engine
This is Rietveld 408576698