Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1864)

Issue 2648623002: ChromeOS OOBE: make "System Security Settings" popup dialog backgroung gray. (Closed)

Created:
3 years, 11 months ago by Alexander Alekseev
Modified:
3 years, 11 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeOS OOBE: make "System Security Settings" popup dialog backgroung gray. This CL makes background style of "System Security Settings" look like "Help App" background dialog that can be launched from the same UI. BUG=604119, 665752 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2648623002 Cr-Commit-Position: refs/heads/master@{#445024} Committed: https://chromium.googlesource.com/chromium/src/+/505b49d17e4048c3dbd4aad632e324c0174cee4b

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update after review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/resources/chromeos/login/oobe.js View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_popup_overlay.css View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
Alexander Alekseev
Please review. (And CQ if this looks good to you.)
3 years, 11 months ago (2017-01-19 22:41:16 UTC) #3
michaelpg
https://codereview.chromium.org/2648623002/diff/1/chrome/browser/resources/chromeos/login/oobe.js File chrome/browser/resources/chromeos/login/oobe.js (right): https://codereview.chromium.org/2648623002/diff/1/chrome/browser/resources/chromeos/login/oobe.js#newcode339 chrome/browser/resources/chromeos/login/oobe.js:339: $('popup-overlay').removeAttribute('md-mode'); sorry, I don't understand why oobe-shield no longer ...
3 years, 11 months ago (2017-01-20 02:15:05 UTC) #9
Alexander Alekseev
https://codereview.chromium.org/2648623002/diff/1/chrome/browser/resources/chromeos/login/oobe.js File chrome/browser/resources/chromeos/login/oobe.js (right): https://codereview.chromium.org/2648623002/diff/1/chrome/browser/resources/chromeos/login/oobe.js#newcode339 chrome/browser/resources/chromeos/login/oobe.js:339: $('popup-overlay').removeAttribute('md-mode'); On 2017/01/20 02:15:05, michaelpg wrote: > sorry, I ...
3 years, 11 months ago (2017-01-20 03:25:18 UTC) #10
Alexander Alekseev
3 years, 11 months ago (2017-01-20 03:25:20 UTC) #11
michaelpg
lgtm
3 years, 11 months ago (2017-01-20 09:19:03 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2648623002/20001
3 years, 11 months ago (2017-01-20 09:19:16 UTC) #18
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 09:24:01 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/505b49d17e4048c3dbd4aad632e3...

Powered by Google App Engine
This is Rietveld 408576698