ChromeOS OOBE: make "System Security Settings" popup dialog backgroung gray.

ChromeOS OOBE: make "System Security Settings" popup dialog backgroung gray.

This CL makes background style of "System Security Settings" look like
"Help App" background dialog that can be launched from the same UI.

BUG=604119, 665752
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2648623002
Cr-Commit-Position: refs/heads/master@{#445024}
Committed: https://chromium.googlesource.com/chromium/src/+/505b49d17e4048c3dbd4aad632e324c0174cee4b

[Alexander Alekseev, 2017-01-19 22:39:49]

Description was changed from

==========
ChromeOS OOBE: make "System Security Settings" popup dialog backgroung gray.

This CL makes background style of "System Security Settings" look like
"Help App" background dialog that can be launched from the same UI.

BUG=604119
==========

to

==========
ChromeOS OOBE: make "System Security Settings" popup dialog backgroung gray.

This CL makes background style of "System Security Settings" look like
"Help App" background dialog that can be launched from the same UI.

BUG=604119
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Alexander Alekseev, 2017-01-19 22:41:16]

alemate@chromium.org changed reviewers:
+ michaelpg@chromium.org

[Alexander Alekseev, 2017-01-19 22:41:16]

Please review. (And CQ if this looks good to you.)

[Alexander Alekseev, 2017-01-19 22:41:22]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[Alexander Alekseev, 2017-01-19 22:41:51]

Description was changed from

==========
ChromeOS OOBE: make "System Security Settings" popup dialog backgroung gray.

This CL makes background style of "System Security Settings" look like
"Help App" background dialog that can be launched from the same UI.

BUG=604119
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
ChromeOS OOBE: make "System Security Settings" popup dialog backgroung gray.

This CL makes background style of "System Security Settings" look like
"Help App" background dialog that can be launched from the same UI.

BUG=604119,665752
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2017-01-19 22:42:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 00:13:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 00:13:41]

Dry run: This issue passed the CQ dry run.

[michaelpg, 2017-01-20 02:15:05]

https://codereview.chromium.org/2648623002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe.js (right):

https://codereview.chromium.org/2648623002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe.js:339:
$('popup-overlay').removeAttribute('md-mode');
sorry, I don't understand why oobe-shield no longer needs the md-mode attribute
removed in this case. Was this change intentional?

[Alexander Alekseev, 2017-01-20 03:25:18]

https://codereview.chromium.org/2648623002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe.js (right):

https://codereview.chromium.org/2648623002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe.js:339:
$('popup-overlay').removeAttribute('md-mode');
On 2017/01/20 02:15:05, michaelpg wrote:
> sorry, I don't understand why oobe-shield no longer needs the md-mode
attribute
> removed in this case. Was this change intentional?

You're right. I missed this copy-paste error.
Done.

[Alexander Alekseev, 2017-01-20 03:26:04]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 03:26:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 04:32:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 04:32:41]

Dry run: This issue passed the CQ dry run.

[michaelpg, 2017-01-20 09:19:03]

lgtm

[michaelpg, 2017-01-20 09:19:07]

The CQ bit was checked by michaelpg@chromium.org

[commit-bot: I haz the power, 2017-01-20 09:19:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 09:23:30]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484903947303040,
"parent_rev": "6432181413b6162f3e78704987fe0f7c61e7c185", "commit_rev":
"505b49d17e4048c3dbd4aad632e324c0174cee4b"}

[commit-bot: I haz the power, 2017-01-20 09:23:59]

Description was changed from

==========
ChromeOS OOBE: make "System Security Settings" popup dialog backgroung gray.

This CL makes background style of "System Security Settings" look like
"Help App" background dialog that can be launched from the same UI.

BUG=604119,665752
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
ChromeOS OOBE: make "System Security Settings" popup dialog backgroung gray.

This CL makes background style of "System Security Settings" look like
"Help App" background dialog that can be launched from the same UI.

BUG=604119,665752
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2648623002
Cr-Commit-Position: refs/heads/master@{#445024}
Committed:
https://chromium.googlesource.com/chromium/src/+/505b49d17e4048c3dbd4aad632e3...
==========

[commit-bot: I haz the power, 2017-01-20 09:24:01]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/505b49d17e4048c3dbd4aad632e3...